backpatch tests: Rename conflicting role names to 14/15

Started by Sami Imseih1 day ago4 messages
#1Sami Imseih
Sami Imseih
samimseih@gmail.com

Hi,

On 15 STABLE, I encountered the same issue [0]/messages/by-id/ZvTneMVPdsMYwTQE@paquier.xyz which was fixed in 6a20b04f0408
starting from 16. It seems like a decision not to backpatch to lower
versions at the
time was due to a lack of reports [1]/messages/by-id/20221003234111.4ob7yph6r4g4ywhu@awork3.anarazel.de, but I think since we have to
support 14 and 15 for
a few more years, it makes sense to. I can prepare the patches if there are no
objections.

[0]: /messages/by-id/ZvTneMVPdsMYwTQE@paquier.xyz
[1]: /messages/by-id/20221003234111.4ob7yph6r4g4ywhu@awork3.anarazel.de

--
Sami Imseih
Amazon Web Services (AWS)

#2Michael Paquier
Michael Paquier
michael@paquier.xyz
In reply to: Sami Imseih (#1)
Re: backpatch tests: Rename conflicting role names to 14/15

On Wed, Dec 10, 2025 at 04:39:11PM -0600, Sami Imseih wrote:

On 15 STABLE, I encountered the same issue [0] which was fixed in 6a20b04f0408
starting from 16. It seems like a decision not to backpatch to lower
versions at the time was due to a lack of reports [1], but I think since we have to
support 14 and 15 for a few more years, it makes sense to.

The issue is that Sami has been able to trigger this problem
internally. :)

I can prepare the patches if there are no objections.

If you could prepare a patch, that would be great! Let's do that if
v14 and v15 can also face the issue under a high-concurrent build.
The blast area of 6a20b04f0408 is not that bad.
--
Michael

#3Sami Imseih
Sami Imseih
samimseih@gmail.com
In reply to: Michael Paquier (#2)
2 attachment(s)
Re: backpatch tests: Rename conflicting role names to 14/15

I can prepare the patches if there are no objections.

If you could prepare a patch, that would be great! Let's do that if
v14 and v15 can also face the issue under a high-concurrent build.
The blast area of 6a20b04f0408 is not that bad.

"make-installcheck --jobs 8" has reproduced the conflict almost
consistently between adminpack and plperl tests.

cherry-pick to 15 had no conflicts. 14 does not have the
plperl_setup_scratch schema, so I had to fix that.

See the attached.

--
Sami Imseih
Amazon Web Services

Attachments:

0001-tests-Rename-conflicting-role-names.patch.15_STABLEapplication/octet-stream; name=0001-tests-Rename-conflicting-role-names.patch.15_STABLE
0001-tests-Rename-conflicting-role-names.patch.14_STABLEapplication/octet-stream; name=0001-tests-Rename-conflicting-role-names.patch.14_STABLE
#4Michael Paquier
Michael Paquier
michael@paquier.xyz
In reply to: Sami Imseih (#3)
Re: backpatch tests: Rename conflicting role names to 14/15

On Wed, Dec 10, 2025 at 06:57:56PM -0600, Sami Imseih wrote:

"make-installcheck --jobs 8" has reproduced the conflict almost
consistently between adminpack and plperl tests.

cherry-pick to 15 had no conflicts. 14 does not have the
plperl_setup_scratch schema, so I had to fix that.

See the attached.

Thanks for the patches. These look correct, so applied to v15 and
v14.
--
Michael