Re: pgsql: Revert "Avoid requiring Spanish locale to test NLS infrastructur

Christoph Berg <myon@debian.org> writes:

The Debian package builds are complaining that there is now a
usr/share/locale/es/LC_MESSAGES/regress-19.mo
file that needs sorting into one of the .deb packages.
Since regress.so itself doesn't get installed by autoconf's Makefiles,
shouldn't that .mo file not get installed either? (Or resolve it the
other way round and install both.)

Hm. I don't really care to revisit the decision not to install
regress.so. OTOH, if we don't install the .mo file, "make
installcheck" will not work, which is surely a nonstarter.
(Also, I see no provisions in either build system to build a
non-installed .mo file.)

Is it possible to override that packaging complaint?

regards, tom lane

Re: Tom Lane

Is it possible to override that packaging complaint?

Sure, we'd just have to install it. It just seemed asymmetric to do
that when regress.so isn't installed. (TBH I've been pondering to do
that anyway to make re-running the regression tests later easier.)

"regress-19.mo" is a pretty generic name for a file installed in a
system-wide location. Perhaps it could be named postgresql-regress-19.mo?
(pg_regress(-19).mo doesn't exist yet, but might appear independently.)

Christoph

Christoph Berg <myon@debian.org> writes:

"regress-19.mo" is a pretty generic name for a file installed in a
system-wide location. Perhaps it could be named postgresql-regress-19.mo?
(pg_regress(-19).mo doesn't exist yet, but might appear independently.)

Fair point, I'll look into renaming that later.

regards, tom lane

I wrote:

Christoph Berg <myon@debian.org> writes:

"regress-19.mo" is a pretty generic name for a file installed in a
system-wide location. Perhaps it could be named postgresql-regress-19.mo?
(pg_regress(-19).mo doesn't exist yet, but might appear independently.)

Fair point, I'll look into renaming that later.

Done at 5b4fb2b97d2.

regards, tom lane