Run perltidy on src/test/perl/PostgreSQL/Test/Cluster.pm

Started by Xuneng Zhou9 months ago3 messageshackers
Beta feature

Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.

appliessuccessCI history

You can run a PostgreSQL built from this patch straight from Docker, with no checkout and no build:

docker run --rm -p 5432:5432 ghcr.io/hackorum-dev/postgres-patch:t52968
psql -h localhost -U postgres

Built from patchset v1 (message #1), September 20, 2026 at 02:04 AM.

Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:

git clone --branch t52968_1 https://github.com/hackorum-dev/postgres.git

In a checkout you already have, add the fork once:

git remote add hackorum https://github.com/hackorum-dev/postgres.git

then, for this patchset and every later one:

git fetch hackorum t52968_1 && git checkout t52968_1

Patchset v1 (message #1) is on t52968_1

Jump to latest
#1Xuneng Zhou
xunengzhou@gmail.com

Hi Hackers,

This patch implements $subject.

--
Best,
Xuneng

Attachments:

t52968_1
0001-Run-perltidy-on-src-test-perl-PostgreSQL-Test-Cluste.patchapplication/octet-stream; name=0001-Run-perltidy-on-src-test-perl-PostgreSQL-Test-Cluste.patchDownload+5-8
#2Michael Paquier
michael@paquier.xyz
In reply to: Xuneng Zhou (#1)
Re: Run perltidy on src/test/perl/PostgreSQL/Test/Cluster.pm

On Sat, Dec 27, 2025 at 12:47:35AM +0800, Xuneng Zhou wrote:

This patch implements $subject.

FWIW, perltidy is run globally across the tree once a year before
forking a new stable branch, or is let up to committers. I don't see
why we should do that now.
--
Michael

#3Xuneng Zhou
xunengzhou@gmail.com
In reply to: Michael Paquier (#2)
Re: Run perltidy on src/test/perl/PostgreSQL/Test/Cluster.pm

Hi Michael,

On Sat, Dec 27, 2025 at 7:34 AM Michael Paquier <michael@paquier.xyz> wrote:

On Sat, Dec 27, 2025 at 12:47:35AM +0800, Xuneng Zhou wrote:

This patch implements $subject.

FWIW, perltidy is run globally across the tree once a year before
forking a new stable branch, or is let up to committers. I don't see
why we should do that now.
--
Michael

I wasn’t aware of this before — thanks for pointing it out. I ran
perltidy on patch 4 of [1]/messages/by-id/CABPTF7WDzTs2EEB6c5QmsV-svF4rKSTLOS1pWM+7ydUN6tnFOQ@mail.gmail.com and noticed there are several untidy
sections that do not stem from the changes introduced in this patch.
So I created this thread and the patch.

[1]: /messages/by-id/CABPTF7WDzTs2EEB6c5QmsV-svF4rKSTLOS1pWM+7ydUN6tnFOQ@mail.gmail.com

--
Best,
Xuneng