fix a spelling mistake
Hi Hackers,
When I was reading the comment of the function bt_report_duplicate(), I discovered a spelling mistake. Therefore, I sent a patch to fix this issue.
Regards,
Yang Yuanzhuo
Attachments:
v1-0001-Correct-the-spelling-error-of-constraint.patchapplication/octet-stream; charset=utf-8; name=v1-0001-Correct-the-spelling-error-of-constraint.patchDownload
From bf63bf070e8b41b669a1f860d104c71d2da830c6 Mon Sep 17 00:00:00 2001
From: yangyuanzhuo <1197620467@qq.com>
Date: Thu, 15 Jan 2026 17:38:32 +0800
Subject: [PATCH v1] Correct the spelling error of constraint
Author: Yang Yuanzhuo <1197620467@qq.com>
---
contrib/amcheck/verify_nbtree.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/contrib/amcheck/verify_nbtree.c b/contrib/amcheck/verify_nbtree.c
index 7733ab2..2089177 100644
--- a/contrib/amcheck/verify_nbtree.c
+++ b/contrib/amcheck/verify_nbtree.c
@@ -862,7 +862,7 @@ heap_entry_is_visible(BtreeCheckState *state, ItemPointer tid)
}
/*
- * Prepare an error message for unique constrain violation in
+ * Prepare an error message for unique constraint violation in
* a btree index and report ERROR.
*/
static void
--
1.8.3.1
On Fri, Jan 16, 2026 at 08:58:06AM +0800, yangyz wrote:
When I was reading the comment of the function
bt_report_duplicate(), I discovered a spelling mistake. Therefore, I
sent a patch to fix this issue.
Thanks for the report. I have grabbed this fix and will apply all
these things once the stack gets bigger.
--
Michael
On Jan 16, 2026, at 11:19, Michael Paquier <michael@paquier.xyz> wrote:
On Fri, Jan 16, 2026 at 08:58:06AM +0800, yangyz wrote:
When I was reading the comment of the function
bt_report_duplicate(), I discovered a spelling mistake. Therefore, I
sent a patch to fix this issue.Thanks for the report. I have grabbed this fix and will apply all
these things once the stack gets bigger.
--
Michael
Hi Michael,
I can add a couple to your stack:
1 - This one I ever reported, but was missed in 94a24b4ee5a
```
diff --git a/src/backend/commands/extension.c b/src/backend/commands/extension.c
index 596105ee078..a9529692ae3 100644
--- a/src/backend/commands/extension.c
+++ b/src/backend/commands/extension.c
@@ -2398,7 +2398,7 @@ pg_available_extension_versions(PG_FUNCTION_ARGS)
/*
* Ignore already-found names. They are not reachable by the
- * path search, so don't shown them.
+ * path search, so don't show them.
*/
extname_str = makeString(extname);
if (list_member(found_ext, extname_str))
```
2 - I happened to notice this one yesterday while reviewing your patch, but I hesitated to file a trivial patch, so I didn’t.
```
diff --git a/src/backend/statistics/extended_stats_funcs.c b/src/backend/statistics/extended_stats_funcs.c
index b4b1bf26463..c0af146451e 100644
--- a/src/backend/statistics/extended_stats_funcs.c
+++ b/src/backend/statistics/extended_stats_funcs.c
@@ -120,7 +120,7 @@ delete_pg_statistic_ext_data(Oid stxoid, bool inherited)
HeapTuple oldtup;
bool result = false;
- /* Is there already a pg_statistic tuple for this attribute? */
+ /* Is there already a pg_statistic_ext_data tuple for this attribute? */
oldtup = SearchSysCache2(STATEXTDATASTXOID,
ObjectIdGetDatum(stxoid),
BoolGetDatum(inherited));
```
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
On Fri, Jan 16, 2026 at 02:54:40PM +0800, Chao Li wrote:
- /* Is there already a pg_statistic tuple for this attribute? */ + /* Is there already a pg_statistic_ext_data tuple for this attribute? */ oldtup = SearchSysCache2(STATEXTDATASTXOID, ObjectIdGetDatum(stxoid), BoolGetDatum(inherited));
Indeed, this one is on me. Thanks for the summary. :)
--
Michael