Apr 2026

5 commits
pg_regress: Include diffs in TAP output
2 Apr 2026Andrew Dunstanmaster19beta1REL_19_STABLE19beta1
LLM analysis, 99% suremodified before commitlight changesfrom patchset #122 of 5 reviewers saw the final version

The src/test/regress/pg_regress.c implementation matches the first patch in #12, including DIAG_DETAIL/DIAG_END, Windows-safe reopening, and the combined 80-line limit. The committer rewrote the subject and explanatory message.

  • Andrew Dunstansaw the final versiontrailerHe gave an initial positive review in #8 and committed the final version, announcing it in #14.
  • Corey Huinkersaw the final versiontrailerHe tested intentionally failing regression output and requested comment punctuation in #11, then verified the final submission in #13.
  • Zsolt Parragino review foundtrailerHis specific reviews in #2 and #9 concern Perl command helpers rather than pg_regress diff emission.
  • Nazir Bilal Yavuzsaw an earlier versiontrailerHe identified incorrect counting of long diff lines in #6, before new diagnostic states and Windows file-handling fixes were added.
  • Andres Freundsaw an earlier versiontrailerHe requested bounded diff output and questioned the diff execution changes in #3, before truncation, long-line handling, and Windows fixes were implemented.
perl tap: Show failed command output
2 Apr 2026Andrew Dunstanmaster19beta1REL_19_STABLE19beta1
LLM analysis, 99% suremodified before commitlight changesfrom patchset #124 of 5 reviewers saw the final version

Matches the second patch in #12 in src/test/perl/PostgreSQL/Test/Utils.pm and src/bin/pg_ctl/t/001_start_stop.pl, apart from removing a blank line. The committer also rewrote the explanatory message.

  • Andrew Dunstansaw the final versiontrailerHe reviewed the series positively in #8 and committed its final version, as reported in #14.
  • Corey Huinkersaw the final versiontrailerHe tested the improved command output and explicitly approved the helper patch in #11, then confirmed passing tests in #13.
  • Zsolt Parragisaw the final versiontrailerHe caught obsolete run_log documentation in #2 and missing command-start logging in #9, after which only that small diagnostic restoration and editorial changes followed.
  • Nazir Bilal Yavuzsaw the final versiontrailerHe approved the command-output patch while questioning descriptor lifetime in #6, and subsequent changes only restored command-start logging and tidied presentation.
  • Andres Freundsaw an earlier versiontrailerHe challenged tempfile overhead, unlimited output, and duplicated formatting in #3, prompting substantial revisions to capture and truncation.
perl tap: Show die reason in TAP output
2 Apr 2026Andrew Dunstanmaster19beta1REL_19_STABLE19beta1Also in: bailing out in tap tests nearly always a bad idea
LLM analysis, 99% suremodified before commitlight changesfrom patchset #122 of 5 reviewers saw the final version

The 18-line __DIE__ handler addition in src/test/perl/PostgreSQL/Test/Utils.pm matches the third patch in #12 exactly. The landed commit replaces the submitted explanatory message with a shorter description.

  • Andrew Dunstansaw the final versiontrailerHe gave the series a positive initial review in #8 and reviewed the final implementation as its committer, announcing completion in #14.
  • Corey Huinkersaw the final versiontrailerHe explicitly approved the die-handler patch in #11 and reported passing tests for the final submission in #13.
  • Zsolt Parragino review foundtrailerHis substantive comments in #2 and #9 address command helpers, with no specific review of the die handler shown.
  • Nazir Bilal Yavuzsaw an earlier versiontrailerHe approved the die-handler patch in #6, before #10 added eval protection around done_testing().
  • Andres Freundsaw an earlier versiontrailerHe requested separate syntax-error handling and discussed done_testing() in #3, before those changes and subsequent eval protection were implemented.
perl tap: Use croak instead of die in our helper modules
2 Apr 2026Andrew Dunstanmaster19beta1REL_19_STABLE19beta1
LLM analysis, 100% suremodified before commitmoderate changesfrom patchset #121 of 5 reviewers saw the final version

Retains the fourth patch from #12 and adds @CARP_NOT in src/test/perl/PostgreSQL/Test/Utils.pm so croak skips Cluster.pm wrappers. Andrew explicitly identifies this additional caller-resolution behavior in #14.

  • Andrew Dunstansaw the final versiontrailerHe gave an initial positive review in #8 and committed the final version with his @CARP_NOT addition, described in #14.
  • Corey Huinkersaw an earlier versiontrailerHe approved the croak patch in #11 and tested the final submission in #13, before the committer added cross-package caller handling.
  • Zsolt Parragino review foundtrailerHis concrete reviews in #2 and #9 concern command_ok and command_fails rather than the croak conversion.
  • Nazir Bilal Yavuzsaw an earlier versiontrailerHe said the croak patch looked good in #6, before the additional @CARP_NOT behavior was introduced at commit.
  • Andres Freundsaw an earlier versiontrailerHe proposed replacing localized caller tracking with croak throughout the helper modules and mentioned @CARP_NOT in #3, before the replacement implementation was posted.
Use command_ok for pg_regress calls in 002_pg_upgrade and 027_stream_regress
2 Apr 2026Andrew Dunstanmaster19beta1REL_19_STABLE19beta1
LLM analysis, 99% suremodified before commitlight changesfrom patchset #122 of 2 reviewers saw the final version

The changes to src/bin/pg_upgrade/t/002_pg_upgrade.pl and src/test/recovery/t/027_stream_regress.pl match the fifth patch in #12. The committer rewrote its subject and explanatory message without changing the implementation.

  • Andrew Dunstansaw the final versiontrailerAs committer he reviewed the landed version and announced the series' completion in #14.
  • Corey Huinkersaw the final versiontrailerHe tested the recovery failure output and suggested shortening the message in #11, then confirmed clean application and passing tests in #13.

Credits across 5 commits

Author
Jelte Fennema-Nio5
Reviewer
Andrew Dunstan5
Corey Huinker5
Andres Freund4
Nazir Bilal Yavuz4
Zsolt Parragi4
Committer
Andrew Dunstan5