Correction to comment of brin_range_deserialize
Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.
You can run a PostgreSQL built from this patch straight from Docker, with no checkout and no build:
docker run --rm -p 5432:5432 ghcr.io/hackorum-dev/postgres-patch:t53196psql -h localhost -U postgresBuilt from patchset v1 (message #1), July 27, 2026 at 04:32 AM.
Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:
git clone --branch t53196_1 https://github.com/hackorum-dev/postgres.gitIn a checkout you already have, add the fork once:
git remote add hackorum https://github.com/hackorum-dev/postgres.gitthen, for this patchset and every later one:
git fetch hackorum t53196_1 && git checkout t53196_1Patchset v1 (message #1) is on t53196_1
Hi Hackers,
I found an issue in the comments of the
src/backend/access/brin/brin_minmax_multi.c file.
The header comment of function brin_range_deserialize currently reads:
"Serialize the in-memory representation into a compact varlena value."
which looks like a copy/paste error, where "Serialize" should be
"Deserialize".
I'm posting this patch to fix the comment.
Regards,
ji xu
On Jan 28, 2026, at 16:10, ji xu <thanksgreed@gmail.com> wrote:
Hi Hackers,
I found an issue in the comments of the src/backend/access/brin/brin_minmax_multi.c file.
The header comment of function brin_range_deserialize currently reads:
"Serialize the in-memory representation into a compact varlena value."which looks like a copy/paste error, where "Serialize" should be "Deserialize".
I'm posting this patch to fix the comment.
Regards,
ji xu
<v1-0001-Correction-to-comment-of-brin_range_deserialize.patch>
Indeed, like a copy-pasto from the initial commit (ab59610) where the 2 functions (serialize/deserialize) were added.
The updated comment in the patch looks good to me.
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
On Thu, Jan 29, 2026 at 07:13:44AM +0800, Chao Li wrote:
Indeed, like a copy-pasto from the initial commit (ab59610) where
the 2 functions (serialize/deserialize) were added.The updated comment in the patch looks good to me.
Clearly a copy-pasto. I've picked up that for later, thanks for the
report.
--
Michael