Get rid of the pre-C11 _Alignof define in zic.c

Started by Bertrand Drouvot8 months ago2 messageshackers
Beta feature

Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.

won't retrysuccessCI history

You can run a PostgreSQL built from this patch straight from Docker, with no checkout and no build:

docker run --rm -p 5432:5432 ghcr.io/hackorum-dev/postgres-patch:t53241
psql -h localhost -U postgres

Built from patchset v1 (message #1), July 27, 2026 at 04:20 AM.

Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:

git clone --branch t53241_1 https://github.com/hackorum-dev/postgres.git

In a checkout you already have, add the fork once:

git remote add hackorum https://github.com/hackorum-dev/postgres.git

then, for this patchset and every later one:

git fetch hackorum t53241_1 && git checkout t53241_1

Patchset v1 (message #1) is on t53241_1

Jump to latest
#1Bertrand Drouvot
bertranddrouvot.pg@gmail.com

Hi hackers,

Now that f5e0186f865c is in, I think that we can get rid of this pre-C11 define
and just rely on the C11 _Alignof definition. That's done in the attached.

Note that e6be84356bbb already introduced the usage of _Noreturn in it.

Regards,

--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

Attachments:

t53241_1
v1-0001-Get-rid-of-pre-C11-_Alignof-define-in-zic.c.patchtext/x-diff; charset=us-asciiDownload+0-6
#2Tom Lane
tgl@sss.pgh.pa.us
In reply to: Bertrand Drouvot (#1)
Re: Get rid of the pre-C11 _Alignof define in zic.c

Bertrand Drouvot <bertranddrouvot.pg@gmail.com> writes:

Now that f5e0186f865c is in, I think that we can get rid of this pre-C11 define
and just rely on the C11 _Alignof definition. That's done in the attached.

I'm not in favor of introducing random discrepancies from tzdb
upstream.

(We are well overdue for re-syncing this code with recent tzdb,
but I don't think changes like this one will make that any less
painful.)

regards, tom lane