Remove obsolete SAMESIGN macro
Started by Richard Guo5 months ago2 messageshackers
The SAMESIGN macro was historically used as a helper for manual
integer overflow checks. However, since commit 4d6ad3125 introduced
overflow-aware integer operations, this manual sign-checking logic is
no longer necessary.
The macro remains defined in brin_minmax_multi.c and timestamp.c, but
is not used in either file. Any objections to removing these
definitions to clean things up?
- Richard
Re: Remove obsolete SAMESIGN macro
On 2/19/26 9:40 AM, Richard Guo wrote:
The macro remains defined in brin_minmax_multi.c and timestamp.c, but
is not used in either file. Any objections to removing these
definitions to clean things up?
No, that is dead code only visible within those files so I do not think
anyone would object.
--
Andreas Karlsson
Percona