New isolation test insert-conflict-do-update-4 outputs rows in alternative ordering

Started by Pavel Borisov11 days ago4 messages
Jump to latest
#1Pavel Borisov
pashkin.elfe@gmail.com

Hi, hackers!

New isolation test insert-conflict-do-update-4 was added by commit 4b760a181ab2

Unlike the previous test (insert-conflict-do-update-3) it doesn't
contain an ordering clause, and when run on a table with a custom
access method, it outputs results in a reverse order.

It's a very minor issue, and the proposed fix is just adding the
missing ORDER BY clause.

Other insert-conflict-do-* isolation tests output just one row except
the mentioned insert-conflict-do-update-3 and
insert-conflict-do-update-4.

The patch is attached

Kind regards,
Pavel Borisov
Supabase

Attachments:

v1-0001-Fix-sorting-of-output-rows-in-a-new-isolation-tes.patchapplication/octet-stream; name=v1-0001-Fix-sorting-of-output-rows-in-a-new-isolation-tes.patchDownload+5-6
#2Pavel Borisov
pashkin.elfe@gmail.com
In reply to: Pavel Borisov (#1)
Re: New isolation test insert-conflict-do-update-4 outputs rows in alternative ordering

This fix should also be backported to all releases that have commit
4b760a181ab2 backported.

Pavel Borisov

Show quoted text

On Tue, 24 Feb 2026 at 20:13, Pavel Borisov <pashkin.elfe@gmail.com> wrote:

Hi, hackers!

New isolation test insert-conflict-do-update-4 was added by commit 4b760a181ab2

Unlike the previous test (insert-conflict-do-update-3) it doesn't
contain an ordering clause, and when run on a table with a custom
access method, it outputs results in a reverse order.

It's a very minor issue, and the proposed fix is just adding the
missing ORDER BY clause.

Other insert-conflict-do-* isolation tests output just one row except
the mentioned insert-conflict-do-update-3 and
insert-conflict-do-update-4.

The patch is attached

Kind regards,
Pavel Borisov
Supabase

#3Tom Lane
tgl@sss.pgh.pa.us
In reply to: Pavel Borisov (#1)
Re: New isolation test insert-conflict-do-update-4 outputs rows in alternative ordering

Pavel Borisov <pashkin.elfe@gmail.com> writes:

New isolation test insert-conflict-do-update-4 was added by commit 4b760a181ab2
Unlike the previous test (insert-conflict-do-update-3) it doesn't
contain an ordering clause, and when run on a table with a custom
access method, it outputs results in a reverse order.
It's a very minor issue, and the proposed fix is just adding the
missing ORDER BY clause.

Right, done.

regards, tom lane

#4Pavel Borisov
pashkin.elfe@gmail.com
In reply to: Tom Lane (#3)
Re: New isolation test insert-conflict-do-update-4 outputs rows in alternative ordering

On Wed, 25 Feb 2026 at 19:52, Tom Lane <tgl@sss.pgh.pa.us> wrote:

Pavel Borisov <pashkin.elfe@gmail.com> writes:

New isolation test insert-conflict-do-update-4 was added by commit 4b760a181ab2
Unlike the previous test (insert-conflict-do-update-3) it doesn't
contain an ordering clause, and when run on a table with a custom
access method, it outputs results in a reverse order.
It's a very minor issue, and the proposed fix is just adding the
missing ORDER BY clause.

Right, done.

regards, tom lane

Thank you!
Regards,
Pavel Borisov