[PATCH] libpq: Fix incorrect message type in getBackendKeyData() comment

Started by zourenli6 months ago2 messageshackers
Beta feature

Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.

appliessuccessCI history

You can run a PostgreSQL built from this patch straight from Docker, with no checkout and no build:

docker run --rm -p 5432:5432 ghcr.io/hackorum-dev/postgres-patch:t53400
psql -h localhost -U postgres

Built from patchset v1 (message #1), August 25, 2026 at 01:24 AM.

Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:

git clone --branch t53400_1 https://github.com/hackorum-dev/postgres.git

In a checkout you already have, add the fork once:

git remote add hackorum https://github.com/hackorum-dev/postgres.git

then, for this patchset and every later one:

git fetch hackorum t53400_1 && git checkout t53400_1

Patchset v1 (message #1) is on t53400_1

Jump to latest
#1zourenli
398740848@qq.com

Hi all,  

This is a trivial fix for the comment of getBackendKeyData() function in fe-protocol3.c.  
The comment incorrectly stated that the BackendKeyData message type is 'v', when in fact it is 'K' as defined in protocol.h. This fix corrects the comment to match the actual message type used in the protocol.  
No functional changes are involved.  

Patch is attached below.  

Thanks,  
zourenli  
<398740848@qq.com&gt;

Attachments:

t53400_1
v1-0001-fix-incorrect-message-type-in-getBackendKeyData-comment.patchapplication/octet-stream; charset=utf-8; name=v1-0001-fix-incorrect-message-type-in-getBackendKeyData-comment.patchDownload+2-3
#2Michael Paquier
michael@paquier.xyz
In reply to: zourenli (#1)
Re: [PATCH] libpq: Fix incorrect message type in getBackendKeyData() comment

On Thu, Feb 26, 2026 at 11:01:29AM +0800, zourenli wrote:

This is a trivial fix for the comment of getBackendKeyData() function in fe-protocol3.c. &nbsp;
The comment incorrectly stated that the BackendKeyData message type
is 'v', when in fact it is 'K' as defined in protocol.h. This fix
corrects the comment to match the actual message type used in the
protocol.

As in PqMsg_BackendKeyData, good catch. Grabbed this one.
--
Michael