Remove redundant cast in gindesc.c
Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.
You can run a PostgreSQL built from this patch straight from Docker, with no checkout and no build:
docker run --rm -p 5432:5432 ghcr.io/hackorum-dev/postgres-patch:t53478psql -h localhost -U postgresBuilt from patchset v1 (message #1), July 27, 2026 at 03:25 AM.
Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:
git clone --branch t53478_1 https://github.com/hackorum-dev/postgres.gitIn a checkout you already have, add the fork once:
git remote add hackorum https://github.com/hackorum-dev/postgres.gitthen, for this patchset and every later one:
git fetch hackorum t53478_1 && git checkout t53478_1Patchset v1 (message #1) is on t53478_1
Hi all,
While reviewing the code, I noticed a small detail and made this simple patch.
There are no functional changes; it’s just meant to make the code look a bit cleaner.
```
diff --git a/src/backend/access/rmgrdesc/gindesc.c b/src/backend/access/rmgrdesc/gindesc.c
index 66a0bf0e0e7..4e24a1cdfe7 100644
--- a/src/backend/access/rmgrdesc/gindesc.c
+++ b/src/backend/access/rmgrdesc/gindesc.c
@@ -126,7 +126,7 @@ gin_desc(StringInfo buf, XLogReaderState *record)
ginxlogSplit *xlrec = (ginxlogSplit *) rec; appendStringInfo(buf, "isrootsplit: %c",
- (((ginxlogSplit *) rec)->flags & GIN_SPLIT_ROOT) ? 'T' : 'F');
+ (xlrec->flags & GIN_SPLIT_ROOT) ? 'T' : 'F');
appendStringInfo(buf, " isdata: %c isleaf: %c",
(xlrec->flags & GIN_INSERT_ISDATA) ? 'T' : 'F',
(xlrec->flags & GIN_INSERT_ISLEAF) ? 'T' : 'F');
```--
regards,
Man Zeng
On Tue, Mar 10, 2026 at 09:31:33AM +0800, zengman wrote:
While reviewing the code, I noticed a small detail and made this simple patch.
There are no functional changes; it’s just meant to make the code look a bit cleaner.
Thanks, grabbed this one for later.
--
Michael