pg_restore: TAP test case typo(wrong word) for an error hint in 001_basic.pl
Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.
You can run a PostgreSQL built from this patch straight from Docker, with no checkout and no build:
docker run --rm -p 5432:5432 ghcr.io/hackorum-dev/postgres-patch:t53508psql -h localhost -U postgresBuilt from patchset v1 (message #1), September 20, 2026 at 01:16 AM.
Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:
git clone --branch t53508_1 https://github.com/hackorum-dev/postgres.gitIn a checkout you already have, add the fork once:
git remote add hackorum https://github.com/hackorum-dev/postgres.gitthen, for this patchset and every later one:
git fetch hackorum t53508_1 && git checkout t53508_1Patchset v1 (message #1) is on t53508_1
Hi,
While doing some changes, I found a typo error(wrong word) in 001_basic.pl
file.
In 31a8b77a9244a0883e1968adc, we added some test cases for pg_dump,
pg_restore and pg_dumpall.
In one error case, we added 'pg_dump' name instead of 'pg_rsetore'.
diff --git a/src/bin/pg_dump/t/001_basic.pl b/src/bin/pg_dump/t/001_basic.pl
index 9f12ca6c51d..ff1d422292e 100644
--- a/src/bin/pg_dump/t/001_basic.pl
+++ b/src/bin/pg_dump/t/001_basic.pl
@@ -144,7 +144,7 @@ command_fails_like(
command_fails_like(
[ 'pg_restore', '-f -', '-F', 'garbage' ],
qr/\Qpg_restore: error: unrecognized archive format "garbage";\E/,
- 'pg_dump: unrecognized archive format');
+ 'pg_restore: unrecognized archive format');Here, I am attaching a patch to fix this.This patch can be applied till
PG14.
I think we should back-patch till PG14. Please review this.
--
Thanks and Regards
Mahendra Singh Thalor
EnterpriseDB: http://www.enterprisedb.com
On Sun, Mar 15, 2026 at 10:59:53PM +0530, Mahendra Singh Thalor wrote:
I think we should back-patch till PG14. Please review this.
Thanks, grabbed this one for later. I am not sure if it is worth
bothering about the back-branches. If somebody feels otherwise,
please feel free to overwrite me and I will adapt.
--
Michael
Thanks Michael for the review.
Please can you push this change into master?
Thanks and Regards
Mahendra Singh Thalor
EnterpriseDB: http://www.enterprisedb.com
On Mon, 16 Mar 2026 at 4:59 AM, Michael Paquier <michael@paquier.xyz> wrote:
Show quoted text
On Sun, Mar 15, 2026 at 10:59:53PM +0530, Mahendra Singh Thalor wrote:
I think we should back-patch till PG14. Please review this.
Thanks, grabbed this one for later. I am not sure if it is worth
bothering about the back-branches. If somebody feels otherwise,
please feel free to overwrite me and I will adapt.
--
Michael
On Fri, Mar 20, 2026 at 01:33:00AM +0530, Mahendra Singh Thalor wrote:
Please can you push this change into master?
I took care of this in commit ec80215c03.
--
nathan
On Fri, 20 Mar 2026 at 01:37, Nathan Bossart <nathandbossart@gmail.com> wrote:
On Fri, Mar 20, 2026 at 01:33:00AM +0530, Mahendra Singh Thalor wrote:
Please can you push this change into master?
I took care of this in commit ec80215c03.
--
nathan
Thanks Nathan. I only saw the commit message. Apologize.
--
Thanks and Regards
Mahendra Singh Thalor
EnterpriseDB: http://www.enterprisedb.com