did this ever get integrated ? (for OpenBSD)

Started by Peter Galbavyalmost 27 years ago3 messagesbugs
Jump to latest
#1Peter Galbavy
Peter.Galbavy@knowledge.com

Did anyone ever pick this up ?

(Please ignore the #if 1 ... 'endif - this was a quick test hack, since
I lost the original patch :)

Index: postgresql/src/backend/utils/error/elog.c
diff -c postgresql/src/backend/utils/error/elog.c:1.1.1.3 postgresql/src/backend/utils/error/elog.c:1.2
*** postgresql/src/backend/utils/error/elog.c:1.1.1.3   Mon Mar 29 11:45:58 1999
--- postgresql/src/backend/utils/error/elog.c   Mon Mar 29 12:40:50 1999
***************
*** 7,13 ****
   *
   *
   * IDENTIFICATION
!  *      $Header: /a/cvs/postgresql/src/backend/utils/error/elog.c,v 1.1.1.3 1999/03/29 10:45:58 peter Exp $
   *
   *-------------------------------------------------------------------------
   */
--- 7,13 ----
   *
   *
   * IDENTIFICATION
!  *      $Header: /a/cvs/postgresql/src/backend/utils/error/elog.c,v 1.2 1999/03/29 11:40:50 peter Exp $
   *
   *-------------------------------------------------------------------------
   */
***************
*** 23,28 ****
--- 23,29 ----
  #include <errno.h>
  #include <unistd.h>
  #include <signal.h>
+ #include <setjmp.h>
  #ifdef USE_SYSLOG
  #include <syslog.h>
***************
*** 221,228 ****
--- 222,235 ----
                ProcReleaseSpins(NULL); /* get rid of spinlocks we hold */
                if (!InError)
                {
+ #if 1
+                       extern sigjmp_buf Warn_restart;
+ 
+                       siglongjmp(Warn_restart, 1);
+ #else
                        kill(MyProcPid, SIGQUIT);       /* abort to traffic cop */
                        pause();
+ #endif
                }

/*

--
Peter Galbavy
Knowledge Matters Ltd
http://www.knowledge.com /http://www.wonderland.org/ http://www.literature.org/

#2Bruce Momjian
bruce@momjian.us
In reply to: Peter Galbavy (#1)
Re: [BUGS] did this ever get integrated ? (for OpenBSD)

Yes, this was applied. Not sure when.

Did anyone ever pick this up ?

(Please ignore the #if 1 ... 'endif - this was a quick test hack, since
I lost the original patch :)

Index: postgresql/src/backend/utils/error/elog.c
diff -c postgresql/src/backend/utils/error/elog.c:1.1.1.3 postgresql/src/backend/utils/error/elog.c:1.2
*** postgresql/src/backend/utils/error/elog.c:1.1.1.3   Mon Mar 29 11:45:58 1999
--- postgresql/src/backend/utils/error/elog.c   Mon Mar 29 12:40:50 1999
***************
*** 7,13 ****
*
*
* IDENTIFICATION
!  *      $Header: /a/cvs/postgresql/src/backend/utils/error/elog.c,v 1.1.1.3 1999/03/29 10:45:58 peter Exp $
*
*-------------------------------------------------------------------------
*/
--- 7,13 ----
*
*
* IDENTIFICATION
!  *      $Header: /a/cvs/postgresql/src/backend/utils/error/elog.c,v 1.2 1999/03/29 11:40:50 peter Exp $
*
*-------------------------------------------------------------------------
*/
***************
*** 23,28 ****
--- 23,29 ----
#include <errno.h>
#include <unistd.h>
#include <signal.h>
+ #include <setjmp.h>
#ifdef USE_SYSLOG
#include <syslog.h>
***************
*** 221,228 ****
--- 222,235 ----
ProcReleaseSpins(NULL); /* get rid of spinlocks we hold */
if (!InError)
{
+ #if 1
+                       extern sigjmp_buf Warn_restart;
+ 
+                       siglongjmp(Warn_restart, 1);
+ #else
kill(MyProcPid, SIGQUIT);       /* abort to traffic cop */
pause();
+ #endif
}

/*

--
Peter Galbavy
Knowledge Matters Ltd
http://www.knowledge.com /http://www.wonderland.org/ http://www.literature.org/

-- 
  Bruce Momjian                        |  http://www.op.net/~candle
  maillist@candle.pha.pa.us            |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026
#3Ole Gjerde
gjerde@icebox.org
In reply to: Bruce Momjian (#2)
bin/psql compile fails on Redhat 6.0 (glibc 2.1)

bin/psql is now failing to compile on redhat 6.0.
Libc: glibc 2.1
kernel: 2.2.7(and 2.2.5)
compiler: egcs 1.1.2

This is CVS as of today (monday) at 10am(Central Time).
I believe cvs from friday DID compile.

gcc -I../../interfaces/libpq -I../../include -I../../backend -O2 -Wall
-Wmissing-prototypes -c psql.c -o psql.o
psql.c:152: initializer element is not constant
psql.c: In function `handleCopyIn':
psql.c:3093: warning: `c' might be used uninitialized in this function
make[2]: *** [psql.o] Error 1
make[2]: Leaving directory `/root/new/pgsql/src/bin/psql'