Patch pgsql-7.2 AuthBlockSig

Good catch. I see now that AuthBlockSig is missing in
/src/include/pgsignal.h, but is referenced in pgsignal.c in both #ifdef
and #else cases.

Patch applied to 7.3 and will appear in 7.2.1.

---------------------------------------------------------------------------

Heiko Lehmann wrote:

HAllo!

We had a problem with to compile pgsql-7.2 under SW-8.0.
In the mailing lists I found no informations.
See note for further informations.

regards Heiko

(part of 020221.postgresql-7.2)
## ----------------------------------------------------------------------
## Problem AuthBlockSig
## - linux-2.4.14, sw-8.0, gcc-2.95.3 
# make
...
gcc -O2 -Wall -Wmissing-prototypes -Wmissing-declarations
-I../../../src/include
-c -o pqsignal.o pqsignal.c
pqsignal.c: In function `pqinitmask':
pqsignal.c:122: `AuthBlockSig' undeclared (first use in this function)
pqsignal.c:122: (Each undeclared identifier is reported only once
pqsignal.c:122: for each function it appears in.)
make[3]: *** [pqsignal.o] Error 1
make[3]: Leaving directory `/var/tmp/postgresql-7.2/src/backend/libpq'
make[2]: *** [libpq-recursive] Error 2
make[2]: Leaving directory `/var/tmp/postgresql-7.2/src/backend'
make[1]: *** [all] Error 2
make[1]: Leaving directory `/var/tmp/postgresql-7.2/src'
make: *** [all] Error 2
## Define fuer AuthBlockSig scheint zu fehlen. Bug?!
## in pqsignal.h existieren 2 verschiedene Definitionen
## folgenden Patch einspielen:
## ---%<---
*** ./src/include/libpq/pqsignal.h.org  Mon Nov  5 18:46:33 2001
--- ./src/include/libpq/pqsignal.h      Thu Feb 21 18:51:39 2002
***************
*** 28,34 ****
#define PG_SETMASK(mask)      sigprocmask(SIG_SETMASK, mask, NULL)
#else
extern int    UnBlockSig,
!                       BlockSig;

#define PG_SETMASK(mask)      sigsetmask(*((int*)(mask)))
#endif
--- 28,35 ----
#define PG_SETMASK(mask)      sigprocmask(SIG_SETMASK, mask, NULL)
#else
extern int    UnBlockSig,
!                       BlockSig,
!                       AuthBlockSig;

#define PG_SETMASK(mask) sigsetmask(*((int*)(mask)))
#endif
## ---%<---
## nun ist der Fehler weg. OK.
## --> mailto:pgsql-bugs@postgresql.org
## ----------------------------------------------------------------------

---------------------------(end of broadcast)---------------------------
TIP 1: subscribe and unsubscribe commands go to majordomo@postgresql.org

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

Heiko Lehmann <hlehmann@fh-lausitz.de> writes:

*** ./src/include/libpq/pqsignal.h.org  Mon Nov  5 18:46:33 2001
--- ./src/include/libpq/pqsignal.h      Thu Feb 21 18:51:39 2002
***************
*** 28,34 ****
#define PG_SETMASK(mask)      sigprocmask(SIG_SETMASK, mask, NULL)
#else
extern int    UnBlockSig,
!                       BlockSig;

#define PG_SETMASK(mask)      sigsetmask(*((int*)(mask)))
#endif
--- 28,35 ----
#define PG_SETMASK(mask)      sigprocmask(SIG_SETMASK, mask, NULL)
#else
extern int    UnBlockSig,
!                       BlockSig,
!                       AuthBlockSig;

#define PG_SETMASK(mask) sigsetmask(*((int*)(mask)))
#endif

How embarrassing :-(. Will apply.

regards, tom lane