plpython plpy.log/warning minor aesthetic bug

Started by eleinover 23 years ago4 messagesbugs
Jump to latest
#1elein
elein@norcov.com

Postgres7.3b1, Linux Suse 7.3

plpy.log() and plpy.warning() leave parentheses and a trailing
comma on messages in psql and in the log. I did not test
the other plpy interfaces to elog. This is what they look like:
WARNING: ('This is a warning!',)
LOG: ('This is a log message.',)

The parens are OK, but the trailing comma bothers my
brain parser.

------warnme.sql----

drop function warnme():
create function warnme()
returns text as
'
plpy.warning( "This is a warning!" )
return "warning"

' LANGUAGE 'plpython';

drop function logme();
create function logme()
returns text as
'
plpy.log( "This is a log message." )
return "log message"

' LANGUAGE 'plpython';

select warnme();
select logme();

--
-- Log file results:
--
-- WARNING: ('This is a warning!',)
-- LOG: ('This is a log message.',)

#2Bruce Momjian
bruce@momjian.us
In reply to: elein (#1)
Re: plpython plpy.log/warning minor aesthetic bug

Looks fine here on BSD/OS, in server logs:

LOG: statement: select nested_call_one('pass this along');

---------------------------------------------------------------------------

elein wrote:

Postgres7.3b1, Linux Suse 7.3

plpy.log() and plpy.warning() leave parentheses and a trailing
comma on messages in psql and in the log. I did not test
the other plpy interfaces to elog. This is what they look like:
WARNING: ('This is a warning!',)
LOG: ('This is a log message.',)

The parens are OK, but the trailing comma bothers my
brain parser.

------warnme.sql----

drop function warnme():
create function warnme()
returns text as
'
plpy.warning( "This is a warning!" )
return "warning"

' LANGUAGE 'plpython';

drop function logme();
create function logme()
returns text as
'
plpy.log( "This is a log message." )
return "log message"

' LANGUAGE 'plpython';

select warnme();
select logme();

--
-- Log file results:
--
-- WARNING: ('This is a warning!',)
-- LOG: ('This is a log message.',)

---------------------------(end of broadcast)---------------------------
TIP 3: if posting/reading through Usenet, please send an appropriate
subscribe-nomail command to majordomo@postgresql.org so that your
message can get through to the mailing list cleanly

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073
#3elein
elein@norcov.com
In reply to: Bruce Momjian (#2)
Re: plpython plpy.log/warning minor aesthetic bug

That is very odd.

I wonder if it is whacky on other Linux systems or
if it is something with SuSe.

Or! possibly it is that I am using an older Python. python 2.1.
That is probably it. If so, nevermind. It is very minor
anyway.

elein
elein@norcov.com

Show quoted text

On Sunday 22 September 2002 18:14, you wrote:

Looks fine here on BSD/OS, in server logs:

LOG: statement: select nested_call_one('pass this along');

---------------------------------------------------------------------------

elein wrote:

Postgres7.3b1, Linux Suse 7.3

plpy.log() and plpy.warning() leave parentheses and a trailing
comma on messages in psql and in the log. I did not test
the other plpy interfaces to elog. This is what they look like:
WARNING: ('This is a warning!',)
LOG: ('This is a log message.',)

The parens are OK, but the trailing comma bothers my
brain parser.

------warnme.sql----

drop function warnme():
create function warnme()
returns text as
'
plpy.warning( "This is a warning!" )
return "warning"

' LANGUAGE 'plpython';

drop function logme();
create function logme()
returns text as
'
plpy.log( "This is a log message." )
return "log message"

' LANGUAGE 'plpython';

select warnme();
select logme();

--
-- Log file results:
--
-- WARNING: ('This is a warning!',)
-- LOG: ('This is a log message.',)

---------------------------(end of broadcast)---------------------------
TIP 3: if posting/reading through Usenet, please send an appropriate
subscribe-nomail command to majordomo@postgresql.org so that your
message can get through to the mailing list cleanly

#4Bruce Momjian
bruce@momjian.us
In reply to: elein (#3)
Re: plpython plpy.log/warning minor aesthetic bug

elein wrote:

That is very odd.

I wonder if it is whacky on other Linux systems or
if it is something with SuSe.

Or! possibly it is that I am using an older Python. python 2.1.
That is probably it. If so, nevermind. It is very minor
anyway.

I have python 1.5 here. Do you see it if you run the plpython/test.sh
script?

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073