7.3 RMPS bugs ( pgdb.py and postgresql launch script )

Started by Gaetano Mendolaover 23 years ago4 messagesbugs
Jump to latest
#1Gaetano Mendola
mendola@bigfoot.com

Hi all,

the file pgdb.py distribuited with Postgresql 7.3 RPM ( RedHat 8.0)
is affectd by an error that not permit anymore to use the
pgdb interface for python.

In that file there is present the following query:

SELECT typname, typprtlen, typlen
FROM pg_type WHERE oid = %s" % oid

the column typptrlen do not exist anymore in the table pg_type!!!
So I replace the column with 4 but I don't know if is a good
fix ( BTW my regression tests now are working correctly ).

There is also in the script for launch postgres a couple of errors:
1) the wrong check for the version ( already known )
2) when postgres is launched the script do:
echo " [ OK ] "
or
echo " [ FAIL ] "

but should be more correctly:
echo_success
or
echo_failure

I attach both patch ( I added also the stop_immediate )

Regards
Gaetano Mendola

begin 666 pgdb.py.patch
M+2TM('!G9&(N<'D),C P,BTQ,BTP-R P,3HR-#HQ.2XP,# P,# P,# @+3 Q
M,# **RLK('!G9&(N<'DN=W)O;F<),C P,BTQ,BTP-R P,3HR,CHR,"XP,# P
M,# P,# @+3 Q,# *0$ @+3$T-RPW("LQ-#<L-R! 0 H@"0D)<F5T=7)N('-E
M;&8N7U]T>7!E7V-A8VAE6V]I9%T*( D)97AC97!T.@H@"0D)<V5L9BY?7W-O
M=7)C92YE>&5C=71E* HM"0D)"2)314Q%0U0@='EP;F%M92P@-"P@='EP;&5N
M("(**PD)"0DB4T5,14-4('1Y<&YA;64L('1Y<'!R=&QE;BP@='EP;&5N("(*
M( D)"0DB1E)/32!P9U]T>7!E(%=(15)%(&]I9" ]("5S(B E(&]I9 H@"0D)
F*0H@"0D)<F5S(#T@<V5L9BY?7W-O=7)C92YF971C:"@Q*5LP70H`
`
end

begin 666 postgresql.patch
M+2TM('!O<W1G<F5S<6P),C P,BTQ,BTP-R Q,SHT-3HU-BXP,# P,# P,# @
M+3 Q,# **RLK('!O<W1G<F5S<6PN=W)O;F<),C P,BTQ,BTP-2 P,CHP.#HP
M."XP,# P,# P,# @+3 Q,# *0$ @+30X+#D@*S0X+#@@0$ *(",@5&5S=&5D
M('1H92 D/R!R971U<FX@9F]R('1H92!S=&]P('-C<FEP=" M+2!I="!D;V5S
M(&EN(&9A8W0@<')O<&%G871E+@H@(R!43T1/.B!M=6QT:7!L92!P;W-T;6%S
M=&5R<RX*( HM(R!697)S:6]N(#<N,R!,86UA<B!/5V5N(#QL86UA<BYO=V5N
M0')A;6EF;W)D:7-T870N;F5T/@HK(R!617)S:6]N(#<N,R!,86UA<B!/5V5N
M(#QL86UA<BYO=V5N0')A;6EF;W)D:7-T870N;F5T/@H@(R!-=6QT:7!L92!P
M;W-T;6%S=&5R<RP@8V]U<G1E<WD@2V%R;"!$94)I<W-C:&]P"BTC($%D9&5D
M('-T;W!?:6UM961I871E($=A971A;F\@365N9&]L82 \(&UE;F1O;&% 8FEG
M9F]O="YC;VT^"B *(",@4$=615)324].(&ES.@H@4$=615)324]./3<N,PI
M0" M.3@L-R K.3<L-R! 0 H@"71H96X*( DC($-H96-K('9E<G-I;VX@;V8@
M97AI<W1I;F<@4$=$051!"B *+0D):68@6R!@8V%T("101T1!5$$O4$=?5D52
M4TE/3F @(3T@)S<N,R<@70HK"0EI9B!;(&!C870@)%!'1$%402]01U]615)3
M24].8" A/2 G-RXR)R!="B )"71H96X*( D)"5-94T1/0T1)4CTB*%EO=7(@
M4WES=&5M)W,@9&]C=6UE;G1A=&EO;B!D:7)E8W1O<GDI(@H@"0D):68@6R M
M9" O=7-R+V1O8R]P;W-T9W)E<W%L+2101U9%4E-)3TX@70I 0" M,3$X+#$P
M("LQ,3<L,3<@0$ *( D)"0E365-$3T-$25(]+W5S<B]S:&%R92]D;V,O<&%C
M:V%G97,*( D)"69I"B )"0EE8VAO"BT)"0EE8VAO("0B06X@;VQD('9E<G-I
M;VX@;V8@=&AE(&1A=&%B87-E(&9O<FUA="!W87,@9F]U;F0N7&XB"BT@(" @
M(" @(" @(" @(" @(" @(" @("!E8VAO("0B66]U(&YE960@=&\@=7!G<F%D
M92!T:&4@9&%T82!F;W)M870@8F5F;W)E('5S:6YG(%!O<W1G<F5344PN7&XB
M"BT@(" @(" @(" @(" @(" @(" @(" @("!E8VAO("0B4V5E("1365-$3T-$
M25(O<&]S=&=R97-Q;"TD4$=615)324].+U)%041-12YR<&TM9&ES="!F;W(@
M;6]R92!I;F9O<FUA=&EO;BXB"BL)"0EE8VAO("0B06X@;VQD('9E<G-I;VX@
M;V8@=&AE(&1A=&%B87-E(&9O<FUA="!W87,@9F]U;F0N7&Y9;W4@;F5E9"!T
M;R!U<&=R861E('1H92!D871A(&9O<FUA="!B969O<F4@=7-I;F<@4&]S=&=R
M95-13"Y<;E-E92 D4UE31$]#1$E2+W!O<W1G<F5S<6PM)%!'5D524TE/3B]2
M14%$344N<G!M+61I<W0@9F]R(&UO<F4@:6YF;W)M871I;VXN(@H@"0D)97AI
M=" Q"BLC(" @(" @(" @(" @(" @(" @(" @("!4:&ES(&1O97-N)W0@<V5E
M;2!T;R!D;R!A;GET:&EN9R!U<V5F=6PN+BX**R,)"65L<V4**R,)"0EI9B!E
M8VAO("(D5%E015-%5")\9W)E<" B9&5C;&%R92 M9B!S=6-C97-S("@I(B ^
M+V1E=B]N=6QL"BLC"0D)=&AE;@HK(PD)"0ES=6-C97-S("(D4%-13%]#2$5#
M2R(**R,)"0EE;'-E"BLC"0D)"65C:&\@(B @6R!/2R!=(@HK(PD)"69I"BLC
M"0D)96-H;PH@"0EF:0H@"B )(R!.;R!E>&ES=&EN9R!01T1!5$$A($EN:71D
M8B!I="X*0$ @+3$T."PX("LQ-30L."! 0 H@( EF:0H@"B )(R!#:&5C:R!F
M;W(@<&]S=&UA<W1E<B!A;')E861Y(')U;FYI;F<N+BX*+2 @(" @(" @(R!N
M;W1E('1H870@<&=?8W1L(&]N;'D@;&]O:W,@870@=&AE(&1A=&$@<W1R=6-T
M=7)E<R!I;B!01T1!5$$*+2 @(" @(" @(R!Y;W4@<F5A;&QY(&1O(&YE960@
M=&AE('!I9&]F*"D**R @(R!N;W1E('1H870@<&=?8W1L(&]N;'D@;&]O:W,@
M870@=&AE(&1A=&$@<W1R=6-T=7)E<R!I;B!01T1!5$$**R @(R!Y;W4@<F5A
M;&QY(&1O(&YE960@=&AE('!I9&]F*"D*( EP:60]8'!I9&]F("US("]U<W(O
M8FEN+W!O<W1M87-T97)@"B ):68@6R D<&ED(%T@)B8@+W5S<B]B:6XO<&=?
M8W1L('-T871U<R M1" D4$=$051!(#X@+V1E=B]N=6QL(#(^)C$*( ET:&5N
M"D! ("TQ-C<L-R K,3<S+#<@0$ *( D)"71H96X*( D)"0ES=6-C97-S("(D
M4%-13%]35$%25"(*( D)"65L<V4*+0D)"0EE8VAO7W-U8V-E<W,**PD)"0EE
M8VAO("(@(%L@3TL@72(*( D)"69I"B )"0ET;W5C:" O=F%R+VQO8VLO<W5B
M<WES+R1[3D%-17T*( D)"65C:&\@)'!I9" ^("]V87(O<G5N+W!O<W1M87-T
M97(N)'M01U!/4E1]+G!I9 I 0" M,3<W+#<@*S$X,RPW($! "B )"0ET:&5N
M"B )"0D)9F%I;'5R92 B)%!344Q?4U1!4E0B"B )"0EE;'-E"BT)"0D)96-H
M;U]F86EL=7)E"BL)"0D)96-H;R B(%L@1D%)3$5$(%TB"B )"0EF:0H@"0D)
M96-H;PH@"0EF:0I 0" M,3DY+#(Q("LR,#4L-B! 0 H@"7)M("UF("]V87(O
M;&]C:R]S=6)S>7,O)'M.04U%?0H@?0H@"BUS=&]P7VEM;65D:6%T92@I>PHM
M"65C:&\@+6X@)")3=&]P<&EN9R D>TY!345]('-E<G9I8V4Z("(*+0ES=2 M
M;"!P;W-T9W)E<R M<R O8FEN+W-H("UC("(O=7-R+V)I;B]P9U]C=&P@<W1O
M<" M1" D4$=$051!("US("UM(&EM;65D:6%T92(@/B O9&5V+VYU;&P@,CXF
M,0HM"7)E=#TD/R *+0EI9B!;("1R970@+65Q(# @70HM"71H96X*+0D)96-H
M;U]S=6-C97-S"BT)96QS90HM"0EE8VAO7V9A:6QU<F4*+0EF:0HM"65C:&\*
M+0ER;2 M9B O=F%R+W)U;B]P;W-T;6%S=&5R+B1[4$=03U)4?2YP:60*+0ER
M;2 M9B O=F%R+VQO8VLO<W5B<WES+R1[3D%-17T*+7T*+0H@<F5S=&%R="@I
M>PH@(" @('-T;W *(" @("!S=&%R= I 0" M,C,X+#D@*S(R.2PV($! "B @
M('-T;W I"B )<W1O< H@"3L["BT@('-T;W!?:6UM961I871E*0HM"7-T;W!?
M:6UM961I871E"BT).SL*(" @<W1A='5S*0H@"7-T871U<R!P;W-T;6%S=&5R
M"B ).SL*0$ @+3(U-"PW("LR-#(L-R! 0 H@"7)E;&]A9 H@"3L["B @("HI
M"BT)96-H;R D(E5S86=E.B D,"![<W1A<G1\<W1O<'QS=&]P7VEM;65D:6%T
M97QS=&%T=7-\<F5S=&%R='QC;VYD<F5S=&%R='QR96QO861\9F]R8V4M<F5L
M;V%D?2(**PEE8VAO("0B57-A9V4Z("0P('MS=&%R='QS=&]P?'-T871U<WQR
M97-T87)T?&-O;F1R97-T87)T?')E;&]A9'QF;W)C92UR96QO861](@H@"65X
-:70@,0H@97-A8PH@"@``
`
end

#2Gerhard Häring
haering_linux@gmx.de
In reply to: Gaetano Mendola (#1)
Re: 7.3 RMPS bugs ( pgdb.py and postgresql launch script )

[Removing cross post to pgsql-admin@postgresql.org]

* Gaetano Mendola <mendola@bigfoot.com> [2002-12-08 17:45 +0100]:

Hi all,

the file pgdb.py distribuited with Postgresql 7.3 RPM ( RedHat 8.0)
is affectd by an error that not permit anymore to use the
pgdb interface for python.

In that file there is present the following query:

SELECT typname, typprtlen, typlen
FROM pg_type WHERE oid = %s" % oid

Yeah, looks familiar.

the column typptrlen do not exist anymore in the table pg_type!!! So
I replace the column with 4 but I don't know if is a good fix ( BTW my
regression tests now are working correctly ).

As this value cannot be determined anymore, it's IMO better to set it to
-1 instead. This is what I've done in our alternative PostgreSQL
interface, pyPgSQL (http://pypgsql.sf.net/) and what I've also suggested
to D'Arcy. If I interpreted D'Arcy's response correctly, he's already
fixed this bug in PostgreSQL CVS.

Cheers,

-- Gerhard

#3Lamar Owen
lamar.owen@wgcr.org
In reply to: Gaetano Mendola (#1)
Re: [BUGS] 7.3 RMPS bugs ( pgdb.py and postgresql launch script )

On Sunday 08 December 2002 11:45, Gaetano Mendola wrote:

the file pgdb.py distribuited with Postgresql 7.3 RPM ( RedHat 8.0)
is affectd by an error that not permit anymore to use the
pgdb interface for python.

Then the official 7.3 tarball is also buggy.

There is also in the script for launch postgres a couple of errors:
1) the wrong check for the version ( already known )

And fixed.

2) when postgres is launched the script do:
echo " [ OK ] "
but should be more correctly:
echo_success

Hmmm. I thought that used to work right.... let me check.

I attach both patch ( I added also the stop_immediate )

Many thanks.
--
Lamar Owen
WGCR Internet Radio
1 Peter 4:11

#4Jean-Luc Lachance
jllachan@nsd.ca
In reply to: Gaetano Mendola (#1)
Re: [BUGS] 7.3 RMPS bugs ( pgdb.py and postgresql launch script

Lamar Owen wrote:

[...]

2) when postgres is launched the script do:
echo " [ OK ] "
but should be more correctly:
echo_success

Hmmm. I thought that used to work right.... let me check.

It will work the same (if the format did not change), but I can modify
the echo_* script to email me so I know when a service has been started,
stoped or failed to start.

JLL