BUG #1148: server restarts depending on stats options

Yes, I am aware of this error and will fix it in a few days.

---------------------------------------------------------------------------

PostgreSQL Bugs List wrote:

The following bug has been logged online:

Bug reference: 1148
Logged by: Robert Treat

Email address: xzilla@users.sourceforge.net

PostgreSQL version: 7.5 Dev

Operating system: Slackware Linux 8.1 (Kernel 2.4.18)

Description: server restarts depending on stats options

Details:

set log_statement_stats = true and any of
log_(executer|planner|parser)_stats = true and you will get a database
restart when attempting to connect.

from my logs:

postgres@phppgadmin:/usr/local/pgsql-7.5dev$ cat data/logfile
LOG: received smart shutdown request
LOG: shutting down
LOG: database system is shut down
LOG: database system was shut down at 2004-05-06 12:59:01 PDT
LOG: checkpoint record is at 0/9DDC68
LOG: redo record is at 0/9DDC68; undo record is at 0/0; shutdown TRUE
LOG: next transaction ID: 460; next OID: 17207
LOG: database system is ready
WARNING: statement-level statistics are disabled because parser, planner,
or executor statistics are on
TRAP: BadState("!(((bool) ((CurrentUserId) != 0)))", File: "miscinit.c",
Line: 252)
LOG: server process (PID 22690) was terminated by signal 6
LOG: terminating any other active server processes
WARNING: terminating connection because of crash of another server process
DETAIL: The postmaster has commanded this server process to roll back the
current transaction and exit, because another server process exited
abnormally and possibly corrupted shared memory.
HINT: In a moment you should be able to reconnect to the database and
repeat your command.
LOG: all server processes terminated; reinitializing
LOG: database system was interrupted at 2004-05-06 12:59:02 PDT
LOG: checkpoint record is at 0/9DDC68
LOG: redo record is at 0/9DDC68; undo record is at 0/0; shutdown TRUE
LOG: next transaction ID: 460; next OID: 17207
LOG: database system was not properly shut down; automatic recovery in
progress
LOG: record with zero length at 0/9DDCA8
LOG: redo is not required
LOG: database system is ready

this is from a snapshot build on may 5th

---------------------------(end of broadcast)---------------------------
TIP 9: the planner will ignore your desire to choose an index scan if your
joining column's datatypes do not match

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

I have applied the attached patch to fix this problem. Sample output
is:

test=> set log_statement_stats = true;
SET
test=> set log_parser_stats = true;
ERROR: Can not enable parameter when "log_statement_stats" is true.
test=> begin;
BEGIN
test=> set log_statement_stats = false;
SET
test=> set log_parser_stats = true;
SET
test=> commit;
COMMIT
test=> set log_statement_stats = true;
ERROR: Can not enable "log_statement_stats" when "log_parser_stats",
"log_planner_stats", or "log_executor_stats" is true.

And setting postgresql.conf with conflicting options puts this in the
server logs:

FATAL: Can not enable "log_statement_stats" when "log_parser_stats",
"log_planner_stats", or "log_executor_stats" is true.

---------------------------------------------------------------------------

PostgreSQL Bugs List wrote:

The following bug has been logged online:

Bug reference: 1148
Logged by: Robert Treat

Email address: xzilla@users.sourceforge.net

PostgreSQL version: 7.5 Dev

Operating system: Slackware Linux 8.1 (Kernel 2.4.18)

Description: server restarts depending on stats options

Details:

set log_statement_stats = true and any of
log_(executer|planner|parser)_stats = true and you will get a database
restart when attempting to connect.

from my logs:

postgres@phppgadmin:/usr/local/pgsql-7.5dev$ cat data/logfile
LOG: received smart shutdown request
LOG: shutting down
LOG: database system is shut down
LOG: database system was shut down at 2004-05-06 12:59:01 PDT
LOG: checkpoint record is at 0/9DDC68
LOG: redo record is at 0/9DDC68; undo record is at 0/0; shutdown TRUE
LOG: next transaction ID: 460; next OID: 17207
LOG: database system is ready
WARNING: statement-level statistics are disabled because parser, planner,
or executor statistics are on
TRAP: BadState("!(((bool) ((CurrentUserId) != 0)))", File: "miscinit.c",
Line: 252)
LOG: server process (PID 22690) was terminated by signal 6
LOG: terminating any other active server processes
WARNING: terminating connection because of crash of another server process
DETAIL: The postmaster has commanded this server process to roll back the
current transaction and exit, because another server process exited
abnormally and possibly corrupted shared memory.
HINT: In a moment you should be able to reconnect to the database and
repeat your command.
LOG: all server processes terminated; reinitializing
LOG: database system was interrupted at 2004-05-06 12:59:02 PDT
LOG: checkpoint record is at 0/9DDC68
LOG: redo record is at 0/9DDC68; undo record is at 0/0; shutdown TRUE
LOG: next transaction ID: 460; next OID: 17207
LOG: database system was not properly shut down; automatic recovery in
progress
LOG: record with zero length at 0/9DDCA8
LOG: redo is not required
LOG: database system is ready

this is from a snapshot build on may 5th

---------------------------(end of broadcast)---------------------------
TIP 9: the planner will ignore your desire to choose an index scan if your
joining column's datatypes do not match

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

Bruce Momjian wrote:

I have applied the attached patch to fix this problem. Sample output
is:

test=> set log_statement_stats = true;
SET
test=> set log_parser_stats = true;
ERROR: Can not enable parameter when "log_statement_stats" is true.

According to message style guide (and English dictionary):

ERROR: cannot ... is true

Peter Eisentraut wrote:

Bruce Momjian wrote:

I have applied the attached patch to fix this problem. Sample output
is:

test=> set log_statement_stats = true;
SET
test=> set log_parser_stats = true;
ERROR: Can not enable parameter when "log_statement_stats" is true.

According to message style guide (and English dictionary):

ERROR: cannot ... is true

Thanks:

errmsg("cannot enable parameter when \"log_statement_stats\" is true.")));
errmsg("cannot enable \"log_statement_stats\" when \"log_parser_stats\",\n"
"\"log_planner_stats\", or \"log_executor_stats\" is true.")));

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

Bruce Momjian <pgman@candle.pha.pa.us> writes:

Thanks:

errmsg("cannot enable parameter when \"log_statement_stats\" is true.")));
errmsg("cannot enable \"log_statement_stats\" when \"log_parser_stats\",\n"
"\"log_planner_stats\", or \"log_executor_stats\" is true.")));

Still not right: no trailing period on errmsg() strings.

regards, tom lane

Tom Lane wrote:

Bruce Momjian <pgman@candle.pha.pa.us> writes:

Thanks:

errmsg("cannot enable parameter when \"log_statement_stats\" is true.")));
errmsg("cannot enable \"log_statement_stats\" when \"log_parser_stats\",\n"
"\"log_planner_stats\", or \"log_executor_stats\" is true.")));

Still not right: no trailing period on errmsg() strings.

Yea, found that after posting. Fixed another problem one in guc.c.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073