BUG #1219: pgxs does not work fully
The following bug has been logged online:
Bug reference: 1219
Logged by: Fabien COELHO
Email address: coelho@cri.ensmp.fr
PostgreSQL version: 8.0 Beta
Operating system: Linux debian
Description: pgxs does not work fully
Details:
When testing the pgxs framework with various contribs,
some (at least pgbench) do not compile because:
(1) missing file: libpgport.*
(2) non adapted macros: libpq_*dir
(3) testing the feature is not easy because
the makefiles in contrib do not allow to use it,
so one has to fix the makefiles first.
Moreover I really think that even if Peter finds it useless it should be
allowed to use pgxs for contribs
especially as it may be useful to others and as it
does not necessarily harm.
I'm planing to submit yet another patch so as to fix
this again while still preserving the vpath behavior.
Please find enclose a submission to fix these problems.
The patch adds missing the "libpgport.a" file to the installation under
"install-all-headers". It is needed by some contribs. I install the
library in "pkglibdir", but I was wondering whether it should be "libdir"?
I was wondering also whether it would make sense to have a "libpgport.so"?
It fixes various macros which are used by contrib makefiles, especially
libpq_*dir and LDFLAGS when used under PGXS. It seems to me that they are
needed to
It adds the ability to test and use PGXS with contribs, with "make
USE_PGXS=1". Without the macro, this is exactly as before, there should be
no difference, esp. wrt the vpath feature that seemed broken by previous
submission. So it should not harm anybody, and it is useful at least to me.
It fixes some inconsistencies in various contrib makefiles
(useless override, ":=" instead of "=").
It works for me. it validates.
I'm available to fix any problem with this patch.
Have a nice day,
--
Fabien Coelho - coelho@cri.ensmp.fr
Attachments:
install_build_2.patchtext/plain; charset=US-ASCII; name=install_build_2.patchDownload+421-230
Am Dienstag, 17. August 2004 14:26 schrieb Fabien COELHO:
The patch adds missing the "libpgport.a" file to the installation under
"install-all-headers". It is needed by some contribs. I install the
library in "pkglibdir", but I was wondering whether it should be "libdir"?
Yes it should. Please change it.
--
Peter Eisentraut
http://developer.postgresql.org/~petere/
Am Dienstag, 17. August 2004 14:26 schrieb Fabien COELHO:
The patch adds missing the "libpgport.a" file to the installation under
"install-all-headers". It is needed by some contribs. I install the
library in "pkglibdir", but I was wondering whether it should be "libdir"?Yes it should. Please change it.
Dear Peter, dear patchers,
Please find attached a small patch against current CVS head that fixes
pgport library installation so that it goes to libdir instead of
pkglibdir. It works for me.
Have a nice day,
--
Fabien Coelho - coelho@cri.ensmp.fr
Attachments:
pgport_install_fix.patchtext/plain; charset=US-ASCII; name=pgport_install_fix.patchDownload+6-6
Patch applied. Thanks.
---------------------------------------------------------------------------
Fabien COELHO wrote:
Am Dienstag, 17. August 2004 14:26 schrieb Fabien COELHO:
The patch adds missing the "libpgport.a" file to the installation under
"install-all-headers". It is needed by some contribs. I install the
library in "pkglibdir", but I was wondering whether it should be "libdir"?Yes it should. Please change it.
Dear Peter, dear patchers,
Please find attached a small patch against current CVS head that fixes
pgport library installation so that it goes to libdir instead of
pkglibdir. It works for me.Have a nice day,
--
Fabien Coelho - coelho@cri.ensmp.fr
Content-Description:
[ Attachment, skipping... ]
---------------------------(end of broadcast)---------------------------
TIP 1: subscribe and unsubscribe commands go to majordomo@postgresql.org
--
Bruce Momjian | http://candle.pha.pa.us
pgman@candle.pha.pa.us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073