Re: rc4 and rc3, some deleted, but still needed text in the documentation, please put it back again

Started by Magnus Haganderabout 21 years ago5 messagesbugs
Jump to latest
#1Magnus Hagander
magnus@hagander.net

If PostgreSQL is intalled with native language support with
the windows installer and if German is used as locale, local
characters like Umlaute are displayed wrong in the windows
command window. In PG-Admin's Helpfile, which is from beta5,
but no longer in the documentation of version rc3 and rc4,
the following advice can be found:

This information is still in the documentation, it has moved to a
different location. It's in the docmentation for the psql tool now.
(It's under Client Application)

Perhaps on Windows, PostgreSQL should itself send "cmd.exe /c
chcp 1252"
to the console if needed.

1252 is not valid for all installations. Only for Latin-1 installations.

That said, it should be possible to determine this from the system
locale on installation time and put that in the shortcut. Please
register a feature request on the pgFoundry page for this so it's not
forgotten. It won't be there in time for 8.0, but it shouldn't be too
much work to add it in a followon release.

//Magnus

#2Christoph Becker
cgbecker@gmx.de
In reply to: Magnus Hagander (#1)
Re: rc4 and rc3, some deleted, but still needed text in the

Magnus Hagander wrote:

This information is still in the documentation, it has moved to a
different location. It's in the docmentation for the psql tool now.
(It's under Client Application)

Yes it is, but the message in the source code has not been changed,
which is very misleading,
as you can see here:
g:\home\cb>psql -U postgres template1
Password:
Welcome to psql 8.0.0rc5, the PostgreSQL interactive terminal.
......
Warning: Console codepage (850) differs from windows codepage (1252)
8-bit characters will not work correctly. See PostgreSQL
documentation "Installation on Windows" for details.

Regards
Christoph Becker

Magnus Hagander schrieb:

Show quoted text

If PostgreSQL is intalled with native language support with
the windows installer and if German is used as locale, local
characters like Umlaute are displayed wrong in the windows
command window. In PG-Admin's Helpfile, which is from beta5,
but no longer in the documentation of version rc3 and rc4,
the following advice can be found:

This information is still in the documentation, it has moved to a
different location. It's in the docmentation for the psql tool now.
(It's under Client Application)

Perhaps on Windows, PostgreSQL should itself send "cmd.exe /c
chcp 1252"
to the console if needed.

1252 is not valid for all installations. Only for Latin-1 installations.

That said, it should be possible to determine this from the system
locale on installation time and put that in the shortcut. Please
register a feature request on the pgFoundry page for this so it's not
forgotten. It won't be there in time for 8.0, but it shouldn't be too
much work to add it in a followon release.

//Magnus

#3Magnus Hagander
magnus@hagander.net
In reply to: Christoph Becker (#2)
Re: rc4 and rc3, some deleted, but still needed text in the

Magnus Hagander wrote:

This information is still in the documentation, it has moved to a
different location. It's in the docmentation for the psql tool now.
(It's under Client Application)

Yes it is, but the message in the source code has not been
changed, which is very misleading, as you can see here:
g:\home\cb>psql -U postgres template1
Password:
Welcome to psql 8.0.0rc5, the PostgreSQL interactive terminal.
......
Warning: Console codepage (850) differs from windows codepage (1252)
8-bit characters will not work correctly. See PostgreSQL
documentation "Installation on Windows" for details.

Good point :-)

Tom, want to do the honours, or do you want a patch? It's the message in
psql that you mentioned wasn't translatable. Location of docs changed.

//Magnus

#4Tom Lane
tgl@sss.pgh.pa.us
In reply to: Magnus Hagander (#3)
Re: rc4 and rc3, some deleted, but still needed text in the

"Magnus Hagander" <mha@sollentuna.net> writes:

Tom, want to do the honours, or do you want a patch? It's the message in
psql that you mentioned wasn't translatable. Location of docs changed.

Yeah, it's on my must-fix list, but there's no point in fixing it until
we decide where it should point to ;-). I'm still waiting for some
enlightenment on whether this is a psql-only issue or whether we need to
move the information someplace else.

regards, tom lane

#5Magnus Hagander
magnus@hagander.net
In reply to: Tom Lane (#4)
Re: rc4 and rc3, some deleted, but still needed text in the

Tom, want to do the honours, or do you want a patch? It's

the message

in psql that you mentioned wasn't translatable. Location of

docs changed.

Yeah, it's on my must-fix list, but there's no point in
fixing it until we decide where it should point to ;-). I'm
still waiting for some enlightenment on whether this is a
psql-only issue or whether we need to move the information
someplace else.

It's an issue that affects any console mode programs. It may also affect
things like createdb if you try to create a database with chars > 127,
but I'm not 100% sure on that. I would *guess* that psql is the only one
where people will actually care...

//Magnus