Solaris - psql returns 0 instead of 1 for file not found.

I have applied the following patch to 8.1beta and 8.0.X to return the
proper failure value for a psql -f filename open failure.

The bug was that process_file() was returning false for failure, while
the call site expected MainLoop() return values, meaning false/0 was
success.

---------------------------------------------------------------------------

Clark, Andrew wrote:

Hi all,

I've found the when psql is used with the -f flag and the specified file
doesn't exist the rc value is 0.

$ uname -a
SunOS bld 5.8 Generic_108528-29 sun4u sparc SUNW,Sun-Fire-V440

$ psql -V
psql (PostgreSQL) 8.0.2

$ ls foo
foo: No such file or directory

$ psql -f foo
foo: No such file or directory

$ echo $?
0

However, in the man page for psql it says:

EXIT STATUS
psql returns 0 to the shell if it finished normally, 1 if a
fatal error of its own (out of memory, file not found)
occurs, ...

I'm assuming this is the same with other platforms, but I only use
PostgreSQL on Solaris.

Has this been fix in 8.0.3?

Cheers,
Andrew

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

On Monday 19 September 2005 14:01, Clark, Andrew wrote:

Hi all,

I've found the when psql is used with the -f flag and the specified file
doesn't exist the rc value is 0.

$ uname -a
SunOS bld 5.8 Generic_108528-29 sun4u sparc SUNW,Sun-Fire-V440

$ psql -V
psql (PostgreSQL) 8.0.2

$ ls foo
foo: No such file or directory

$ psql -f foo
foo: No such file or directory

$ echo $?
0

However, in the man page for psql it says:

EXIT STATUS
psql returns 0 to the shell if it finished normally, 1 if a
fatal error of its own (out of memory, file not found)
occurs, ...

I'm assuming this is the same with other platforms, but I only use
PostgreSQL on Solaris.

Has this been fix in 8.0.3?

Redirecting to -bugs since I've confirmed this behavior on Slackware Linux 10
with psql version 8.1beta1 and there does seem to be something wrong with the
above situation (perhaps the man page needs to be reworded?)

--
Robert Treat
Build A Brighter Lamp :: Linux Apache {middleware} PostgreSQL

A patch has been applied and this will be fixed in 8.0.4 and 8.1beta3.

---------------------------------------------------------------------------

Robert Treat wrote:

On Monday 19 September 2005 14:01, Clark, Andrew wrote:

Hi all,

I've found the when psql is used with the -f flag and the specified file
doesn't exist the rc value is 0.

$ uname -a
SunOS bld 5.8 Generic_108528-29 sun4u sparc SUNW,Sun-Fire-V440

$ psql -V
psql (PostgreSQL) 8.0.2

$ ls foo
foo: No such file or directory

$ psql -f foo
foo: No such file or directory

$ echo $?
0

However, in the man page for psql it says:

EXIT STATUS
psql returns 0 to the shell if it finished normally, 1 if a
fatal error of its own (out of memory, file not found)
occurs, ...

I'm assuming this is the same with other platforms, but I only use
PostgreSQL on Solaris.

Has this been fix in 8.0.3?

Redirecting to -bugs since I've confirmed this behavior on Slackware Linux 10
with psql version 8.1beta1 and there does seem to be something wrong with the
above situation (perhaps the man page needs to be reworded?)

--
Robert Treat
Build A Brighter Lamp :: Linux Apache {middleware} PostgreSQL

---------------------------(end of broadcast)---------------------------
TIP 6: explain analyze is your friend

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073