Build problem and patch with Sun cc

Started by Steve Nicolaiabout 25 years ago2 messageshackers
Jump to latest
#1Steve Nicolai
snicolai@mac.com

I did a cvs pull of the head on 3/24/01 and used Sun's cc
compiler 5.0 (with all patches as of 2/1/01) to build.

I ran into a problem building pg_backup_null.c rev 1.5.
The following patch lets me build:

Index: src/bin/pg_dump/pg_backup_null.c
===================================================================
RCS file: 
/home/projects/pgsql/cvsroot/pgsql/src/bin/pg_dump/pg_backup_null.c,v
retrieving revision 1.5
diff -u -r1.5 pg_backup_null.c
--- src/bin/pg_dump/pg_backup_null.c    2001/03/22 04:00:13     1.5
+++ src/bin/pg_dump/pg_backup_null.c    2001/03/24 22:00:07
@@ -98,7 +98,7 @@
 static void
 _PrintTocData(ArchiveHandle *AH, TocEntry *te, RestoreOptions *ropt)
 {
-       if (*te->dataDumper)
+       if (te->dataDumper)
        {
                AH->currToc = te;
           (*te->dataDumper) ((Archive *) AH, te->oid, te->dataDumperArg);

Sun's cc complains that *te->dataDumper is not a scalar type.

Steve Nicolai

#2Tom Lane
tgl@sss.pgh.pa.us
In reply to: Steve Nicolai (#1)
Re: Build problem and patch with Sun cc

Steve Nicolai <snicolai@mac.com> writes:

diff -u -r1.5 pg_backup_null.c
--- src/bin/pg_dump/pg_backup_null.c    2001/03/22 04:00:13     1.5
+++ src/bin/pg_dump/pg_backup_null.c    2001/03/24 22:00:07
@@ -98,7 +98,7 @@
static void
_PrintTocData(ArchiveHandle *AH, TocEntry *te, RestoreOptions *ropt)
{
-       if (*te->dataDumper)
+       if (te->dataDumper)
{
AH->currToc = te;
(*te->dataDumper) ((Archive *) AH, te->oid, te->dataDumperArg);

Sun's cc complains that *te->dataDumper is not a scalar type.

Applied. Thanks!

regards, tom lane