BUG #3813: PGDLLIMPORT conflict

Started by Nguyen Hoa Phongover 18 years ago2 messagesbugs
Jump to latest
#1Nguyen Hoa Phong
fong_nh@yahoo.com

The following bug has been logged online:

Bug reference: 3813
Logged by: Nguyen Hoa Phong
Email address: fong_nh@yahoo.com
PostgreSQL version: 8.3-beta4
Operating system: Windows
Description: PGDLLIMPORT conflict
Details:

Because of PGDLLIMPORT conflict and so to use palloc we must to declare
(copydir.c):

/*
* On Windows, call non-macro versions of palloc; we can't reference
* CurrentMemoryContext in this file because of PGDLLIMPORT conflict.
*/
#if defined(WIN32) || defined(__CYGWIN__)
#undef palloc
#undef pstrdup
#define palloc(sz) pgport_palloc(sz)
#define pstrdup(str) pgport_pstrdup(str)
#endif
...

But it's the same if we use the other functions of system, such as, SPI
variables (SPI_result, SPI_tuptable, SPI_lastoid, SPI_processed,...),...
So I think that maybe we should have more one define for this:

#if defined(WIN32) || defined(__CYGWIN__)
#define PGDLLIMPORT __declspec (dllexport)
#endif

And so, the using the relations functions (palloc,..) are normal.

#2Tom Lane
tgl@sss.pgh.pa.us
In reply to: Nguyen Hoa Phong (#1)
Re: BUG #3813: PGDLLIMPORT conflict

"Nguyen Hoa Phong" <fong_nh@yahoo.com> writes:

So I think that maybe we should have more one define for this:

#if defined(WIN32) || defined(__CYGWIN__)
#define PGDLLIMPORT __declspec (dllexport)
#endif

You haven't actually explained why this is better, or even why it
won't break things...

regards, tom lane