BUG #5016: dlltool error in libecpg_compatdll.def

2009/8/27 Itagaki Takahiro <itagaki.takahiro@oss.ntt.co.jp>:

The following bug has been logged online:

Bug reference:      5016
Logged by:          Itagaki Takahiro
Email address:      itagaki.takahiro@oss.ntt.co.jp
PostgreSQL version: 8.5 Alpha 1
Operating system:   Windows XP (mingw)
Description:        dlltool error in libecpg_compatdll.def
Details:

I built 8.5alpha1 and found the following errors:

c:\mingw\bin\dlltool:
 Syntax error in def file ./libecpg_compatdll.def:44
 Syntax error in def file ./libecpg_compatdll.def:44
 Syntax error in def file ./libecpg_compatdll.def:44

There is no @ on 42nd function in libecpg_compatdll.def.
----
   byleng                  @ 41
ECPG_informix_reset_sqlca       42
----
seems to be:
----
   byleng                  @ 41
   ECPG_informix_reset_sqlca @ 42
----

Fix applied - exports.txt had a tab in it, instead of spaces, to
separate the field from the number.

Clearly we don't have a regression test that uses this function, or it
would've broken mingw buildfarm members. Should we have that?

--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/

Magnus Hagander <magnus@hagander.net> writes:

Fix applied - exports.txt had a tab in it, instead of spaces, to
separate the field from the number.

Hmm, maybe it would be better to fix whatever sed script is presuming
the form of the whitespace? Because otherwise we'll surely get bitten
again.

regards, tom lane

2009/8/27 Tom Lane <tgl@sss.pgh.pa.us>:

Magnus Hagander <magnus@hagander.net> writes:

Fix applied - exports.txt had a tab in it, instead of spaces, to
separate the field from the number.

Hmm, maybe it would be better to fix whatever sed script is presuming
the form of the whitespace?  Because otherwise we'll surely get bitten
again.

Well, we havent' been bitten by the requirement for years in libpq,
but I guess that's a point.

Given my comfort-level for
sed-embedded-in-makefile-escaping-requirements, I'll be happy to see
someone else do it, given that it'd likely take me 100 tries to get it
right :D

--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/

Magnus Hagander <magnus@hagander.net> writes:

2009/8/27 Tom Lane <tgl@sss.pgh.pa.us>:

Magnus Hagander <magnus@hagander.net> writes:

Fix applied - exports.txt had a tab in it, instead of spaces, to
separate the field from the number.

Hmm, maybe it would be better to fix whatever sed script is presuming
the form of the whitespace? �Because otherwise we'll surely get bitten
again.

Well, we havent' been bitten by the requirement for years in libpq,
but I guess that's a point.

Given my comfort-level for
sed-embedded-in-makefile-escaping-requirements, I'll be happy to see
someone else do it, given that it'd likely take me 100 tries to get it
right :D

I'll fix the Makefiles if you'll fix whatever is the equivalent part of
the MSVC perl scripts ...

regards, tom lane

On Thu, Aug 27, 2009 at 19:41, Tom Lane<tgl@sss.pgh.pa.us> wrote:

Magnus Hagander <magnus@hagander.net> writes:

2009/8/27 Tom Lane <tgl@sss.pgh.pa.us>:

Magnus Hagander <magnus@hagander.net> writes:

Fix applied - exports.txt had a tab in it, instead of spaces, to
separate the field from the number.

Hmm, maybe it would be better to fix whatever sed script is presuming
the form of the whitespace?  Because otherwise we'll surely get bitten
again.

Well, we havent' been bitten by the requirement for years in libpq,
but I guess that's a point.

Given my comfort-level for
sed-embedded-in-makefile-escaping-requirements, I'll be happy to see
someone else do it, given that it'd likely take me 100 tries to get it
right :D

I'll fix the Makefiles if you'll fix whatever is the equivalent part of
the MSVC perl scripts ...

Thanks.

MSVC already gets it right. It uses the perl split() function, which
accepts both spaces and tabs.

--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/