Small syntax error in fmgr.h
Hello PostgreSQL developers,
https://launchpad.net/bugs/458020 reports a small syntax error in
./src/include/fmgr.h:338:
extern int no_such_variable
The trailing semicolon is missing:
"I had to make the changes in the attached patch file in order to use
the PG_MODULE_MAGIC macro.
From a quick scan it looks as though there may also be a similar
problem with PG_FUNCTION_INFO_V1 also on line 329.
"
Thanks,
Martin
--
Martin Pitt | http://www.piware.de
Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org)
Martin Pitt <mpitt@debian.org> writes:
https://launchpad.net/bugs/458020 reports a small syntax error in
./src/include/fmgr.h:338:
extern int no_such_variable
The trailing semicolon is missing:
This is not a bug. You are supposed to write a semicolon after the
call of PG_MODULE_MAGIC. If we put a semicolon into the macro value,
it would break every single correct usage (at least under compilers
that are picky about empty statements outside functions).
The same goes for PG_FUNCTION_INFO_V1.
regards, tom lane
Martin Pitt wrote:
Hello PostgreSQL developers,
https://launchpad.net/bugs/458020 reports a small syntax error in
./src/include/fmgr.h:338:extern int no_such_variable
The trailing semicolon is missing:
The guy forgot to add a trailing semicolon on the line where he uses the
macro. This is not our bug.
--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.