BUG #5889: "Intersects" for polygons broken

"Konrad Garus" <konrad.garus@gmail.com> writes:

&& operator seems to be broken for polygons whose bounding boxes intersect:

select polygon'((0,0), (1,2), (0,2))' && polygon'((0.5, 0), (1,0), (1,1))';
?column?
----------
t
(1 row)

This is fixed as of 9.0; see the release notes at
http://www.postgresql.org/docs/9.0/static/release-9-0.html
which say

Correct calculations of "overlaps" and "contains" operations for polygons (Teodor Sigaev)

The polygon && (overlaps) operator formerly just checked to see
if the two polygons' bounding boxes overlapped. It now does a
more correct check. The polygon @> and <@ (contains/contained
by) operators formerly checked to see if one polygon's vertexes
were all contained in the other; this can wrongly report "true"
for some non-convex polygons. Now they check that all line
segments of one polygon are contained in the other.

regards, tom lane

2011/2/16 Tom Lane <tgl@sss.pgh.pa.us>:

"Konrad Garus" <konrad.garus@gmail.com> writes:

&& operator seems to be broken for polygons whose bounding boxes intersect:

select polygon'((0,0), (1,2), (0,2))' && polygon'((0.5, 0), (1,0), (1,1))';
 ?column?
----------
 t
(1 row)

This is fixed as of 9.0; see the release notes at
http://www.postgresql.org/docs/9.0/static/release-9-0.html
which say

       Correct calculations of "overlaps" and "contains" operations for polygons (Teodor Sigaev)

       The polygon && (overlaps) operator formerly just checked to see
       if the two polygons' bounding boxes overlapped. It now does a
       more correct check. The polygon @> and <@ (contains/contained
       by) operators formerly checked to see if one polygon's vertexes
       were all contained in the other; this can wrongly report "true"
       for some non-convex polygons. Now they check that all line
       segments of one polygon are contained in the other.

Thank you. How about the point of more informative docs that would
explain supported types, automatic conversions and all such caveats
(also for 8.3 and 8.4)?

--
Konrad Garus

On Wed, Feb 16, 2011 at 10:33 AM, Konrad Garus <konrad.garus@gmail.com> wrote:

2011/2/16 Tom Lane <tgl@sss.pgh.pa.us>:

"Konrad Garus" <konrad.garus@gmail.com> writes:

&& operator seems to be broken for polygons whose bounding boxes intersect:

select polygon'((0,0), (1,2), (0,2))' && polygon'((0.5, 0), (1,0), (1,1))';
 ?column?
----------
 t
(1 row)

This is fixed as of 9.0; see the release notes at
http://www.postgresql.org/docs/9.0/static/release-9-0.html
which say

       Correct calculations of "overlaps" and "contains" operations for polygons (Teodor Sigaev)

       The polygon && (overlaps) operator formerly just checked to see
       if the two polygons' bounding boxes overlapped. It now does a
       more correct check. The polygon @> and <@ (contains/contained
       by) operators formerly checked to see if one polygon's vertexes
       were all contained in the other; this can wrongly report "true"
       for some non-convex polygons. Now they check that all line
       segments of one polygon are contained in the other.

Thank you. How about the point of more informative docs that would
explain supported types, automatic conversions and all such caveats
(also for 8.3 and 8.4)?

I think a lot of these things are already documented. Aren't they?

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

http://www.postgresql.org/docs/current/static/functions-geometry.html

I wish it explained what arguments each of the operators accepts, and
whether any automatic conversions take place (like polygon to box in
that 8.3 issue).

What happens when I call ?# or ?- on a polygon and point? Two points? Open path?

Some of these are obvious, but others not so much.

2011/3/8 Robert Haas <robertmhaas@gmail.com>:

On Wed, Feb 16, 2011 at 10:33 AM, Konrad Garus <konrad.garus@gmail.com> wrote:

2011/2/16 Tom Lane <tgl@sss.pgh.pa.us>:

"Konrad Garus" <konrad.garus@gmail.com> writes:

&& operator seems to be broken for polygons whose bounding boxes intersect:

select polygon'((0,0), (1,2), (0,2))' && polygon'((0.5, 0), (1,0), (1,1))';
 ?column?
----------
 t
(1 row)

This is fixed as of 9.0; see the release notes at
http://www.postgresql.org/docs/9.0/static/release-9-0.html
which say

       Correct calculations of "overlaps" and "contains" operations for polygons (Teodor Sigaev)

       The polygon && (overlaps) operator formerly just checked to see
       if the two polygons' bounding boxes overlapped. It now does a
       more correct check. The polygon @> and <@ (contains/contained
       by) operators formerly checked to see if one polygon's vertexes
       were all contained in the other; this can wrongly report "true"
       for some non-convex polygons. Now they check that all line
       segments of one polygon are contained in the other.

Thank you. How about the point of more informative docs that would
explain supported types, automatic conversions and all such caveats
(also for 8.3 and 8.4)?

I think a lot of these things are already documented.  Aren't they?

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Konrad Garus

On Tue, Mar 8, 2011 at 3:20 PM, Konrad Garus <konrad.garus@gmail.com> wrote:

http://www.postgresql.org/docs/current/static/functions-geometry.html

I wish it explained what arguments each of the operators accepts, and
whether any automatic conversions take place (like polygon to box in
that 8.3 issue).

What happens when I call ?# or ?- on a polygon and point? Two points? Open path?

Some of these are obvious, but others not so much.

Hmm, yeah. That looks like it could be improved. It's certainly not
obvious to me what box * point means, for example, even though the
description says scaling/rotation.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Robert Haas wrote:

On Tue, Mar 8, 2011 at 3:20 PM, Konrad Garus <konrad.garus@gmail.com> wrote:

http://www.postgresql.org/docs/current/static/functions-geometry.html

I wish it explained what arguments each of the operators accepts, and
whether any automatic conversions take place (like polygon to box in
that 8.3 issue).

What happens when I call ?# or ?- on a polygon and point? Two points? Open path?

Some of these are obvious, but others not so much.

Hmm, yeah. That looks like it could be improved. It's certainly not
obvious to me what box * point means, for example, even though the
description says scaling/rotation.

Would someone who uses these features please post changes and I will see
that get into the docs? Thanks.

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ It's impossible for everything to be true. +