Incorrect comment in heapam.c

Started by Peter Geogheganalmost 15 years ago6 messagesbugs
Jump to latest
#1Peter Geoghegan
peter@2ndquadrant.com

Line 834 of heapam.c has the following comment:

/*
* This is formatted so oddly so that the correspondence to the macro
* definition in access/heapam.h is maintained.
*/

In fact, that macro is defined in access/htup.h...should it be?

--
Peter Geoghegan       http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training and Services

#2Simon Riggs
simon@2ndQuadrant.com
In reply to: Peter Geoghegan (#1)
Re: Incorrect comment in heapam.c

On Tue, Dec 20, 2011 at 5:50 PM, Peter Geoghegan <peter@2ndquadrant.com> wrote:

Line 834 of heapam.c has the following comment:

/*
 * This is formatted so oddly so that the correspondence to the macro
 * definition in access/heapam.h is maintained.
 */

In fact, that macro is defined in access/htup.h...should it be?

IMHO comment is wrong, code is in the right place.

--
 Simon Riggs                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services

#3Tom Lane
tgl@sss.pgh.pa.us
In reply to: Simon Riggs (#2)
Re: Incorrect comment in heapam.c

Simon Riggs <simon@2ndQuadrant.com> writes:

On Tue, Dec 20, 2011 at 5:50 PM, Peter Geoghegan <peter@2ndquadrant.com> wrote:

In fact, that macro is defined in access/htup.h...should it be?

IMHO comment is wrong, code is in the right place.

It used to be in heapam.h ... evidently, whoever moved it missed this
comment.

regards, tom lane

#4Peter Geoghegan
peter@2ndquadrant.com
In reply to: Tom Lane (#3)
Re: Incorrect comment in heapam.c

On 20 December 2011 18:11, Tom Lane <tgl@sss.pgh.pa.us> wrote:

Simon Riggs <simon@2ndQuadrant.com> writes:

On Tue, Dec 20, 2011 at 5:50 PM, Peter Geoghegan <peter@2ndquadrant.com> wrote:

In fact, that macro is defined in access/htup.h...should it be?

IMHO comment is wrong, code is in the right place.

It used to be in heapam.h ... evidently, whoever moved it missed this
comment.

I imagined that that was the case.

It's a fairly inconsequential bug, but it is worth fixing...

--
Peter Geoghegan       http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training and Services

#5Robert Haas
robertmhaas@gmail.com
In reply to: Peter Geoghegan (#4)
Re: Incorrect comment in heapam.c

On Wed, Dec 21, 2011 at 6:21 AM, Peter Geoghegan <peter@2ndquadrant.com> wrote:

On 20 December 2011 18:11, Tom Lane <tgl@sss.pgh.pa.us> wrote:

Simon Riggs <simon@2ndQuadrant.com> writes:

On Tue, Dec 20, 2011 at 5:50 PM, Peter Geoghegan <peter@2ndquadrant.com> wrote:

In fact, that macro is defined in access/htup.h...should it be?

IMHO comment is wrong, code is in the right place.

It used to be in heapam.h ... evidently, whoever moved it missed this
comment.

I imagined that that was the case.

It's a fairly inconsequential bug, but it is worth fixing...

Fixed.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

#6Peter Geoghegan
peter@2ndquadrant.com
In reply to: Robert Haas (#5)
Re: Incorrect comment in heapam.c

On 17 January 2012 01:37, Robert Haas <robertmhaas@gmail.com> wrote:

It's a fairly inconsequential bug, but it is worth fixing...

Fixed.

Thanks.

--
Peter Geoghegan       http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training and Services