BUG #8193: A few cosmetic misspell fixes.

Started by Veres Lajosalmost 13 years ago4 messagesbugs
Jump to latest
#1Veres Lajos
vlajos@gmail.com

The following bug has been logged on the website:

Bug reference: 8193
Logged by: Lajos Veres
Email address: vlajos@gmail.com
PostgreSQL version: 9.2.4
Operating system: Linux
Description:

Found a few small misspell with this:
https://github.com/vlajos/misspell_fixer

I created a small patch here:
http://www.pastebin.ca/2385261

Lajos

--
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs

#2Michael Paquier
michael@paquier.xyz
In reply to: Veres Lajos (#1)
Re: BUG #8193: A few cosmetic misspell fixes.

On Fri, May 31, 2013 at 1:51 AM, <vlajos@gmail.com> wrote:

The following bug has been logged on the website:

Bug reference: 8193
Logged by: Lajos Veres
Email address: vlajos@gmail.com
PostgreSQL version: 9.2.4
Operating system: Linux
Description:

Found a few small misspell with this:
https://github.com/vlajos/misspell_fixer

I created a small patch here:
http://www.pastebin.ca/2385261

Referring a patch with an external link is bad practice as the external
service you use could disappear, making this patch lost at the same time.
Please attach patches directly with the mails you send.

For the patch, yes OK there are some spell mistakes. However this patch
should only apply on master branch, and not 9.2 as referenced above. Also,
changing the structure name to Extension does not look to be appropriate as
it is a generic name...
--
Michael

#3Stephen Frost
sfrost@snowman.net
In reply to: Michael Paquier (#2)
Re: BUG #8193: A few cosmetic misspell fixes.

* Michael Paquier (michael.paquier@gmail.com) wrote:

Please attach patches directly with the mails you send.

+1.

For the patch, yes OK there are some spell mistakes. However this patch
should only apply on master branch, and not 9.2 as referenced above.

Agreed.

Also,
changing the structure name to Extension does not look to be appropriate as
it is a generic name...

Took a simpler approach and just renamed it to CoverExt, that should
also avoid any confusion with actual extensions.

Thanks,

Stephen

#4Veres Lajos
vlajos@gmail.com
In reply to: Michael Paquier (#2)
Re: BUG #8193: A few cosmetic misspell fixes.

On Sat, 1 Jun 2013, Michael Paquier wrote:

Referring a patch with an external link is bad practice as the external
service you use could disappear, making this patch lost at the same time.
Please attach patches directly with the mails you send.

For the patch, yes OK there are some spell mistakes. However this patch
should only apply on master branch, and not 9.2 as referenced above. Also,
changing the structure name to Extension does not look to be appropriate as
it is a generic name...

I used this form:
http://www.postgresql.org/support/submitbug/
I didnt see any option for uploading patch or choosing trunk.

Anyway sorry for the inconveniences.

--
Veres Lajos
vlajos@gmail.com
+36 20 438 5909

Attachments:

postgresql.misspell_fixes.vlajos.20130530.patchtext/x-diff; NAME=postgresql.misspell_fixes.vlajos.20130530.patchDownload+7-7