SEP_CHAR

Bruce Momjian writes:

I see some use of SEP_CHAR for '/' in the source. Do we want to use it
consistenly, or not use it at all? I can make the change.

I vote for not at all, since there is not at all a use for it.

--
Peter Eisentraut peter_e@gmx.net http://funkturm.homeip.net/~peter

Peter Eisentraut <peter_e@gmx.net> writes:

Bruce Momjian writes:

I see some use of SEP_CHAR for '/' in the source. Do we want to use it
consistenly, or not use it at all? I can make the change.

I vote for not at all, since there is not at all a use for it.

If it's not actually needed for the Cygwin port, I'd vote for taking it
out. It adds clutter to the sources, to no purpose. Also, even if you
fix it to be used consistently *every* place it should be, how long will
it stay that way? Seems practically unmaintainable to me.

regards, tom lane

Peter Eisentraut <peter_e@gmx.net> writes:

Bruce Momjian writes:

I see some use of SEP_CHAR for '/' in the source. Do we want to use it
consistenly, or not use it at all? I can make the change.

I vote for not at all, since there is not at all a use for it.

If it's not actually needed for the Cygwin port, I'd vote for taking it
out. It adds clutter to the sources, to no purpose. Also, even if you
fix it to be used consistently *every* place it should be, how long will
it stay that way? Seems practically unmaintainable to me.

OK, two votes, will be removed shortly.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

Peter Eisentraut <peter_e@gmx.net> writes:

Bruce Momjian writes:

I see some use of SEP_CHAR for '/' in the source. Do we want to use it
consistenly, or not use it at all? I can make the change.

I vote for not at all, since there is not at all a use for it.

If it's not actually needed for the Cygwin port, I'd vote for taking it
out. It adds clutter to the sources, to no purpose. Also, even if you
fix it to be used consistently *every* place it should be, how long will
it stay that way? Seems practically unmaintainable to me.

I see it used by psql and pg_dump and I will leave them alone, assuming
/ is not hardeded elsewhere in that code.

Actually, it is:

sprintf(psqlrc, "%s/.psqlrc", home);

so it seems NT handles '/' anyway.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

Bruce Momjian writes:

Actually, it is:

sprintf(psqlrc, "%s/.psqlrc", home);

so it seems NT handles '/' anyway.

'/' has been a valid path separator when using the C io facilities at
least since Turbo C on MS-DOS.

--
Peter Eisentraut peter_e@gmx.net http://funkturm.homeip.net/~peter

Bruce Momjian <pgman@candle.pha.pa.us> writes:

I see it used by psql and pg_dump and I will leave them alone, assuming
/ is not hardeded elsewhere in that code.

If you're gonna take it out, take it out completely.

regards, tom lane