gram.y comment issue

On Wed, Mar 9, 2016 at 3:04 PM, 张文升 <wensheng.zhang@qunar.com> wrote:

The gram.y includes the line(line:1965):
/* ALTER TABLE <name> ALTER [COLUMN] <colname> SET ( column_parameter =
value [, ... ] ) */
ALTER opt_column ColId RESET reloptions

The comment has the word "SET", but I think that's should be "RESET".

This one needs to be fixed.

src/include/nodes/parsenodes.h line:141
List *distinctClause; /* a list of SortGroupClause's */
The comment has the word "SortGroupClause", but that's should be
"distinctClause".

This one is fine. The name distinctClause here is parser's way of
referring to the SQL construct DISTINCT ON (<list-of-items>) in a
SELECT query, where each member of the list is a SortGroupClause item.

Thanks,
Amit

--
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs

Amit Langote <amitlangote09@gmail.com> writes:

On Wed, Mar 9, 2016 at 3:04 PM, 张文升 <wensheng.zhang@qunar.com> wrote:

The gram.y includes the line(line:1965):
/* ALTER TABLE <name> ALTER [COLUMN] <colname> SET ( column_parameter =
value [, ... ] ) */
ALTER opt_column ColId RESET reloptions
The comment has the word "SET", but I think that's should be "RESET".

This one needs to be fixed.

Agreed, done.

src/include/nodes/parsenodes.h line:141
List *distinctClause; /* a list of SortGroupClause's */
The comment has the word "SortGroupClause", but that's should be
"distinctClause".

This one is fine. The name distinctClause here is parser's way of
referring to the SQL construct DISTINCT ON (<list-of-items>) in a
SELECT query, where each member of the list is a SortGroupClause item.

Yes. It might be surprising if you don't know that ORDER BY, GROUP BY,
and DISTINCT all have a common parsetree representation ... but the
comment is correct as written.

regards, tom lane

--
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs

thanks !

On 2016年03月09日 23:31, Tom Lane wrote:

Amit Langote

--
----------------------
张文升 | PostgreSQL DBA

--
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs