BUG #14201: In psql prompt2 %R can be (

Started by Дилян Палаузовalmost 10 years ago4 messagesbugs
Jump to latest
#1Дилян Палаузов
dpa-postgres@aegee.org

The following bug has been logged on the website:

Bug reference: 14201
Logged by: Dilian Palauzov
Email address: dpa-postgres@aegee.org
PostgreSQL version: 9.5.3
Operating system: Documentation
Description:

doc/sgml/ref/psql-ref.sgml > Advanced Features > Prompting > %R forgets to
state, that in prompt 2 the substitution can be open parenthesis, as seen
in the beginning of the Examples section.

https://git.postgresql.org/gitweb/?p=postgresql.git;a=blob;f=doc/src/sgml/ref/psql-ref.sgml#l3632

--
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs

#2Martín Marqués
martin@2ndquadrant.com
In reply to: Дилян Палаузов (#1)
Re: BUG #14201: In psql prompt2 %R can be (

El 19/06/16 a las 09:11, dpa-postgres@aegee.org escribió:

doc/sgml/ref/psql-ref.sgml > Advanced Features > Prompting > %R forgets to
state, that in prompt 2 the substitution can be open parenthesis, as seen
in the beginning of the Examples section.

https://git.postgresql.org/gitweb/?p=postgresql.git;a=blob;f=doc/src/sgml/ref/psql-ref.sgml#l3632

That's correct, and a good catch.

Could you provide a patch which fixes the documentation?

--
Martín Marqués http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

--
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs

#3Дилян Палаузов
dpa-postgres@aegee.org
In reply to: Martín Marqués (#2)
Re: BUG #14201: In psql prompt2 %R can be (

Hello,

here is a proposed patch.

On 06/19/2016 02:29 PM, Martín Marqués wrote:

El 19/06/16 a las 09:11, dpa-postgres@aegee.org escribió:

doc/sgml/ref/psql-ref.sgml > Advanced Features > Prompting > %R forgets to
state, that in prompt 2 the substitution can be open parenthesis, as seen
in the beginning of the Examples section.

https://git.postgresql.org/gitweb/?p=postgresql.git;a=blob;f=doc/src/sgml/ref/psql-ref.sgml#l3632

That's correct, and a good catch.

Could you provide a patch which fixes the documentation?

---
doc/sgml/ref/psql-ref.sgml > Advanced Features > Prompting > %R forgets to
state, that in prompt 2 the substitution can be an open parenthesis, as
seen in the beginning of the Examples section:

testdb=> CREATE TABLE my_table (
testdb(> first integer not null default 0,
testdb(> second text)
testdb-> ;
CREATE TABLE

diff --git a/doc/src/sgml/ref/psql-ref.sgml b/doc/src/sgml/ref/psql-ref.sgml
index aef7228..972e38a 100644
--- a/doc/src/sgml/ref/psql-ref.sgml
+++ b/doc/src/sgml/ref/psql-ref.sgml
@@ -3630,11 +3630,11 @@ testdb=&gt; <userinput>INSERT INTO my_table VALUES (:'content');</userinput>
          in single-line mode, and <literal>!</literal> if the session is
          disconnected from the database (which can happen if
          <command>\connect</command> fails). In prompt 2 the sequence is
-        replaced by <literal>-</literal>, <literal>*</literal>, a single quote,
+        replaced by <literal>-</literal>, <literal>*</literal>, <literal>(</literal>, a single quote,
          a double quote, or a dollar sign, depending on whether
          <application>psql</application> expects more input because the
          command wasn't terminated yet, because you are inside a
-        <literal>/* ... */</literal> comment, or because you are inside
+        <literal>/* ... */</literal> comment, because psql expects a closing parenthesis, or because you are inside
          a quoted or dollar-escaped string. In prompt 3 the sequence doesn't
          produce anything.
          </para>

--
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs

#4Tom Lane
tgl@sss.pgh.pa.us
In reply to: Дилян Палаузов (#3)
Re: BUG #14201: In psql prompt2 %R can be (

=?UTF-8?B?0JTQuNC70Y/QvSDQn9Cw0LvQsNGD0LfQvtCy?= <dpa-postgres@aegee.org> writes:

On 06/19/2016 02:29 PM, Martín Marqués wrote:

El 19/06/16 a las 09:11, dpa-postgres@aegee.org escribió:

doc/sgml/ref/psql-ref.sgml > Advanced Features > Prompting > %R forgets to
state, that in prompt 2 the substitution can be open parenthesis, as seen
in the beginning of the Examples section.

That's correct, and a good catch.
Could you provide a patch which fixes the documentation?

here is a proposed patch.

This patch didn't apply cleanly for me, but I incorporated the change
along with some extra wordsmithing. Thanks for noticing this oversight!

regards, tom lane

--
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs