BUG #14314: Mismatch of comment of a function.

On Wed, Sep 7, 2016 at 11:42 PM, <t.katsumata1122@gmail.com> wrote:

The following bug has been logged on the website:

Bug reference: 14314
Logged by: Tomonari Katsumata
Email address: t.katsumata1122@gmail.com
PostgreSQL version: 9.6rc1
Operating system: Source Code
Description:

Hello.

I noticed that it isn't proper for a comment for
transformOnConflictClause.

---
940 /*
941 * transformSelectStmt -
942 * transforms an OnConflictClause in an INSERT
943 */
944 static OnConflictExpr *
945 transformOnConflictClause(ParseState *pstate,
946 OnConflictClause *onConflictClause)
947 {
----

It should be "transformOnConflictClause" rather than
"transformSelectStmt".

Attached patch fixes the reported problem. The patch needs to be
applied till the 9.5 stable branch where the on conflict is introduced.

Regards,
Hari Babu
Fujitsu Australia

Thanks, patch applied.

---------------------------------------------------------------------------

On Mon, Sep 12, 2016 at 11:04:14AM +1000, Haribabu Kommi wrote:

On Wed, Sep 7, 2016 at 11:42 PM, <t.katsumata1122@gmail.com> wrote:

The following bug has been logged on the website:

Bug reference:� � � 14314
Logged by:� � � � � Tomonari Katsumata
Email address:� � � t.katsumata1122@gmail.com
PostgreSQL version: 9.6rc1
Operating system:� �Source Code
Description:

Hello.

I noticed that it isn't proper for a comment� for
transformOnConflictClause.

---
�940 /*
�941� * transformSelectStmt -
�942� *� � transforms an OnConflictClause in an INSERT
�943� */
�944 static OnConflictExpr *
�945 transformOnConflictClause(ParseState *pstate,
�946� � � � � � � � � � � � � �OnConflictClause *onConflictClause)
�947 {
----

It should be "transformOnConflictClause" rather than
"transformSelectStmt".

Attached patch fixes the reported problem. The patch needs to be
applied till the 9.5 stable branch where the on conflict is introduced.

Regards,
Hari Babu
Fujitsu Australia

diff --git a/src/backend/parser/analyze.c b/src/backend/parser/analyze.c
index eac86cc..d9085fe 100644
--- a/src/backend/parser/analyze.c
+++ b/src/backend/parser/analyze.c
@@ -938,7 +938,7 @@ transformInsertRow(ParseState *pstate, List *exprlist,
}

/*
- * transformSelectStmt -
+ * transformOnConflictClause -
* transforms an OnConflictClause in an INSERT
*/
static OnConflictExpr *

--
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ As you are, so once was I. As I am, so you will be. +
+                     Ancient Roman grave inscription +

--
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs