BUG #14773: Incorrect documentation for the Relation logical replication message format

Started by Nonameover 8 years ago2 messagesbugs
Jump to latest
#1Noname
kyle@kyleconroy.com

The following bug has been logged on the website:

Bug reference: 14773
Logged by: Kyle Conroy
Email address: kyle@kyleconroy.com
PostgreSQL version: 10beta2
Operating system: macOS
Description:

I'm working on a Golang parser[0]https://github.com/kyleconroy/pgoutput for logical replication. I was trying to
parse a Relation message, but noticed additional bytes at the end of the
message.

It appears the documentation[1]https://www.postgresql.org/docs/devel/static/protocol-logicalrep-message-formats.html is missing two fields: attribute type and
attribute mode[2]https://github.com/postgres/postgres/blob/113b0045e20d40f726a0a30e33214455e4f1385e/src/backend/replication/logical/proto.c#L553.

Thanks!

[0]: https://github.com/kyleconroy/pgoutput
[1]: https://www.postgresql.org/docs/devel/static/protocol-logicalrep-message-formats.html
https://www.postgresql.org/docs/devel/static/protocol-logicalrep-message-formats.html
[2]: https://github.com/postgres/postgres/blob/113b0045e20d40f726a0a30e33214455e4f1385e/src/backend/replication/logical/proto.c#L553
https://github.com/postgres/postgres/blob/113b0045e20d40f726a0a30e33214455e4f1385e/src/backend/replication/logical/proto.c#L553

--
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs

#2Peter Eisentraut
peter_e@gmx.net
In reply to: Noname (#1)
Re: BUG #14773: Incorrect documentation for the Relation logical replication message format

On 8/8/17 02:09, kyle@kyleconroy.com wrote:

I'm working on a Golang parser[0] for logical replication. I was trying to
parse a Relation message, but noticed additional bytes at the end of the
message.

It appears the documentation[1] is missing two fields: attribute type and
attribute mode[2].

Fixed, thanks!

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

--
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs