BUG #14775: Incorrect documentation for the Commit logical replication message format
Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.
You can run a PostgreSQL built from this patch straight from Docker, with no checkout and no build:
docker run --rm -p 5432:5432 ghcr.io/hackorum-dev/postgres-patch:t67798psql -h localhost -U postgresBuilt from patchset v2 (message #2), July 28, 2026 at 05:35 AM.
Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:
git clone --branch t67798_2 https://github.com/hackorum-dev/postgres.gitIn a checkout you already have, add the fork once:
git remote add hackorum https://github.com/hackorum-dev/postgres.gitthen, for this patchset and every later one:
git fetch hackorum t67798_2 && git checkout t67798_2Patchset v2 (message #2) is on t67798_2
The following bug has been logged on the website:
Bug reference: 14775
Logged by: Kyle Conroy
Email address: kyle@kyleconroy.com
PostgreSQL version: 10beta2
Operating system: macOS
Description:
The Commit message format is incorrectly documented. The `flags` field[0]https://github.com/postgres/postgres/blob/master/src/backend/replication/logical/proto.c#L80 is
missing. I ran into this while creating a parser for the messages in
Golang.
[0]: https://github.com/postgres/postgres/blob/master/src/backend/replication/logical/proto.c#L80
https://github.com/postgres/postgres/blob/master/src/backend/replication/logical/proto.c#L80
--
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs
On Wed, Aug 9, 2017 at 2:08 PM, <kyle@kyleconroy.com> wrote:
The following bug has been logged on the website:
Bug reference: 14775
Logged by: Kyle Conroy
Email address: kyle@kyleconroy.com
PostgreSQL version: 10beta2
Operating system: macOS
Description:The Commit message format is incorrectly documented. The `flags` field[0] is
missing. I ran into this while creating a parser for the messages in
Golang.[0]
https://github.com/postgres/postgres/blob/master/src/backend/replication/logical/proto.c#L80
Thank you for reporting. Yeah, it's not used actually for now but
should be documented. Attached patch.
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
On 8/10/17 04:21, Masahiko Sawada wrote:
The Commit message format is incorrectly documented. The `flags` field[0] is
missing. I ran into this while creating a parser for the messages in
Golang.[0]
https://github.com/postgres/postgres/blob/master/src/backend/replication/logical/proto.c#L80Thank you for reporting. Yeah, it's not used actually for now but
should be documented. Attached patch.
Committed, thanks!
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs
On Tue, Aug 15, 2017 at 2:45 AM, Peter Eisentraut
<peter.eisentraut@2ndquadrant.com> wrote:
On 8/10/17 04:21, Masahiko Sawada wrote:
The Commit message format is incorrectly documented. The `flags` field[0] is
missing. I ran into this while creating a parser for the messages in
Golang.[0]
https://github.com/postgres/postgres/blob/master/src/backend/replication/logical/proto.c#L80Thank you for reporting. Yeah, it's not used actually for now but
should be documented. Attached patch.Committed, thanks!
Thank you for committing!
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
--
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs