BUG #16468: Doc: release note 13, missing GUC enable_groupingsets_hash_disk

Started by PG Bug reporting formover 6 years ago4 messagesbugs
Beta feature

Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.

won't retrysuccessCI history

You can run a PostgreSQL built from this patch straight from Docker, with no checkout and no build:

docker run --rm -p 5432:5432 ghcr.io/hackorum-dev/postgres-patch:t70059
psql -h localhost -U postgres

Built from patchset v3 (message #3), August 18, 2026 at 04:21 PM.

Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:

git clone --branch t70059_3 https://github.com/hackorum-dev/postgres.git

In a checkout you already have, add the fork once:

git remote add hackorum https://github.com/hackorum-dev/postgres.git

then, for this patchset and every later one:

git fetch hackorum t70059_3 && git checkout t70059_3

Patchset v3 (message #3) is on t70059_3

Jump to latest
#1PG Bug reporting form
noreply@postgresql.org

The following bug has been logged on the website:

Bug reference: 16468
Logged by: TAKATSUKA Haruka
Email address: harukat@sraoss.co.jp
PostgreSQL version: 13beta1
Operating system: Any
Description:

Allow grouping sets to use hash aggregation with disk storage for large
grouping set results (Jeff Davis)

Previously, hash aggregation was avoided if it was expected to use
more than work_mem memory. This is controlled by enable_hashagg_disk.

It seems to me that the "enable_hashagg_disk" is mistaken for
"enable_groupingsets_hash_disk".

#2Michael Paquier
michael@paquier.xyz
In reply to: PG Bug reporting form (#1)
Re: BUG #16468: Doc: release note 13, missing GUC enable_groupingsets_hash_disk

On Thu, May 28, 2020 at 06:39:34AM +0000, PG Bug reporting form wrote:

It seems to me that the "enable_hashagg_disk" is mistaken for
"enable_groupingsets_hash_disk".

Good catch. This is not fixed yet on HEAD. Adding Bruce in CC as
that's part of the release notes.
--
Michael

#3Bruce Momjian
bruce@momjian.us
In reply to: Michael Paquier (#2)
Re: BUG #16468: Doc: release note 13, missing GUC enable_groupingsets_hash_disk

On Thu, May 28, 2020 at 04:12:53PM +0900, Michael Paquier wrote:

On Thu, May 28, 2020 at 06:39:34AM +0000, PG Bug reporting form wrote:

It seems to me that the "enable_hashagg_disk" is mistaken for
"enable_groupingsets_hash_disk".

Good catch. This is not fixed yet on HEAD. Adding Bruce in CC as
that's part of the release notes.

Thanks, attached patcy applied.

--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EnterpriseDB https://enterprisedb.com

The usefulness of a cup is in its emptiness, Bruce Lee

Attachments:

t70059_3
rel.difftext/x-diff; charset=us-asciiDownload+1-1
#4Michael Paquier
michael@paquier.xyz
In reply to: Bruce Momjian (#3)
Re: BUG #16468: Doc: release note 13, missing GUC enable_groupingsets_hash_disk

On Tue, Jun 02, 2020 at 10:12:04PM -0400, Bruce Momjian wrote:

Thanks, attached patch applied.

Thanks!
--
Michael