Another pgindent request

Started by Tom Laneover 24 years ago3 messageshackers
Jump to latest
#1Tom Lane
tgl@sss.pgh.pa.us

As long as you're hacking pgindent, can you do something about its habit
of sometimes removing all space before a same-line comment? Here's
an example from the 7.1 run (in src/backend/storage/lmgr/proc.c):

***************
*** 607,613 ****
MyProc->waitHolder = holder;
MyProc->waitLockMode = lockmode;

! MyProc->errType = STATUS_OK; /* initialize result for success */

        /* mark that we are waiting for a lock */
        waitingForLock = true;
--- 612,618 ----
        MyProc->waitHolder = holder;
        MyProc->waitLockMode = lockmode;

! MyProc->errType = STATUS_OK;/* initialize result for success */

/* mark that we are waiting for a lock */
waitingForLock = true;
***************

IMHO there should always be at least one space before a same-line
comment.

regards, tom lane

#2Bruce Momjian
bruce@momjian.us
In reply to: Tom Lane (#1)
Re: Another pgindent request

Already handled. I ran it on proc.c and got:

MyProc->errType = STATUS_OK; /* initialize result for success */

The feature was added with:

# add space after comments that start on tab stops
sed 's,;\(/\*.*\*/\)$,; \1,' |

I must have added this since 7.1, probably because of a mention from
you.

As long as you're hacking pgindent, can you do something about its habit
of sometimes removing all space before a same-line comment? Here's
an example from the 7.1 run (in src/backend/storage/lmgr/proc.c):

***************
*** 607,613 ****
MyProc->waitHolder = holder;
MyProc->waitLockMode = lockmode;

! MyProc->errType = STATUS_OK; /* initialize result for success */

/* mark that we are waiting for a lock */
waitingForLock = true;
--- 612,618 ----
MyProc->waitHolder = holder;
MyProc->waitLockMode = lockmode;

! MyProc->errType = STATUS_OK;/* initialize result for success */

/* mark that we are waiting for a lock */
waitingForLock = true;
***************

IMHO there should always be at least one space before a same-line
comment.

regards, tom lane

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026
#3Tom Lane
tgl@sss.pgh.pa.us
In reply to: Bruce Momjian (#2)
Re: Another pgindent request

Bruce Momjian <pgman@candle.pha.pa.us> writes:

I must have added this since 7.1, probably because of a mention from
you.

Oh, okay ... I must've forgot complaining about it before ...

regards, tom lane