BUG #18476: Debian Install Docs have confusing code block structure

Started by PG Bug reporting formalmost 2 years ago2 messagesbugs
Jump to latest
#1PG Bug reporting form
noreply@postgresql.org

The following bug has been logged on the website:

Bug reference: 18476
Logged by: Matthias Hörmann
Email address: matthias.hoermann@saltation.com
PostgreSQL version: 16.3
Operating system: Debian Linux
Description:

On https://www.postgresql.org/download/linux/debian/ the commands to
manually install the repository and the commands to install packages from
the repository are in one big code block and the text before it suggests
that this code block is optional if you use the script above it. However the
script (without parameters at least) only installs the repository, not the
packages from the repository. Maybe two code blocks were accidentally merged
here and the text in between deleted?

#2Alvaro Herrera
alvherre@2ndquadrant.com
In reply to: PG Bug reporting form (#1)
Re: BUG #18476: Debian Install Docs have confusing code block structure

Moved thread to pgsql-www.

On 2024-May-23, PG Bug reporting form wrote:

On https://www.postgresql.org/download/linux/debian/ the commands to
manually install the repository and the commands to install packages from
the repository are in one big code block and the text before it suggests
that this code block is optional if you use the script above it. However the
script (without parameters at least) only installs the repository, not the
packages from the repository. Maybe two code blocks were accidentally merged
here and the text in between deleted?

I agree, it doesn't look good to have a button for "copy script" that
includes a line that installs a package after having enabled the repo.
Much less one that does so without asking for confirmation! That line
should be separate.

I think the attached patch achieves that, but
1) it's untested
2) I'm not sure that a "Copy Script" button is really all that useful
for the "apt install" line, so maybe that part of this patch should be
scrapped.

--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
"People get annoyed when you try to debug them." (Larry Wall)

Attachments:

0001-Split-the-install-script-in-download-linux-debian.patchtext/x-diff; charset=utf-8Download+14-4