BUG #18513: PG17 build on windows generates postgres.exe.lib instead of postgres.lib

Started by PG Bug reporting formalmost 2 years ago4 messagesbugs
Jump to latest
#1PG Bug reporting form
noreply@postgresql.org

The following bug has been logged on the website:

Bug reference: 18513
Logged by: Muralikrishna Bandaru
Email address: muralikrishna.bandaru@enterprisedb.com
PostgreSQL version: 17beta1
Operating system: Windows
Description:

PG17 build on windows is generating postgres.exe.lib. But all the previous
versions generating postgres.lib file. Due to this renaming the extensions
fail to link with this library by default as they expect postgres.lib. For
example here is the link for system_stats project file
https://github.com/EnterpriseDB/system_stats/blob/master/system_stats.vcxproj#L101

This seems like a bug, Can some one please confirm?

#2Peter Eisentraut
peter_e@gmx.net
In reply to: PG Bug reporting form (#1)
Re: BUG #18513: PG17 build on windows generates postgres.exe.lib instead of postgres.lib

On 17.06.24 07:44, PG Bug reporting form wrote:

The following bug has been logged on the website:

Bug reference: 18513
Logged by: Muralikrishna Bandaru
Email address: muralikrishna.bandaru@enterprisedb.com
PostgreSQL version: 17beta1
Operating system: Windows
Description:

PG17 build on windows is generating postgres.exe.lib. But all the previous
versions generating postgres.lib file. Due to this renaming the extensions
fail to link with this library by default as they expect postgres.lib. For
example here is the link for system_stats project file
https://github.com/EnterpriseDB/system_stats/blob/master/system_stats.vcxproj#L101

This seems like a bug, Can some one please confirm?

The attached patch might fix it. At least I appear to get the right
output file name. I don't have the ability to check whether it does the
right thing on Cygwin.

Attachments:

0001-meson-Fix-import-library-name-in-Windows.patchtext/plain; charset=UTF-8; name=0001-meson-Fix-import-library-name-in-Windows.patchDownload+4-5
#3Muralikrishna Bandaru
muralikrishna.bandaru@enterprisedb.com
In reply to: Peter Eisentraut (#2)
Re: BUG #18513: PG17 build on windows generates postgres.exe.lib instead of postgres.lib

On Tue, Jun 18, 2024 at 11:55 AM Peter Eisentraut <peter@eisentraut.org>
wrote:

On 17.06.24 07:44, PG Bug reporting form wrote:

The following bug has been logged on the website:

Bug reference: 18513
Logged by: Muralikrishna Bandaru
Email address: muralikrishna.bandaru@enterprisedb.com
PostgreSQL version: 17beta1
Operating system: Windows
Description:

PG17 build on windows is generating postgres.exe.lib. But all the

previous

versions generating postgres.lib file. Due to this renaming the

extensions

fail to link with this library by default as they expect postgres.lib.

For

example here is the link for system_stats project file

https://github.com/EnterpriseDB/system_stats/blob/master/system_stats.vcxproj#L101

This seems like a bug, Can some one please confirm?

The attached patch might fix it. At least I appear to get the right
output file name. I don't have the ability to check whether it does the
right thing on Cygwin.

Hi Peter,
This patch worked for me. Now postgres.lib is created instead of
postgres.exe.lib. Once you
push this patch to the source repo then I will try to build the extension
(system_stats).

#4Peter Eisentraut
peter_e@gmx.net
In reply to: Muralikrishna Bandaru (#3)
Re: BUG #18513: PG17 build on windows generates postgres.exe.lib instead of postgres.lib

On 18.06.24 13:32, Muralikrishna Bandaru wrote:

The attached patch might fix it.  At least I appear to get the right
output file name.  I don't have the ability to check whether it does
the
right thing on Cygwin.

 Hi Peter,
 This patch worked for me. Now postgres.lib is created instead of
postgres.exe.lib. Once you
 push this patch to the source repo then I will try to build the
extension (system_stats).

committed