BUG #19080: CancelRequest message documentation bug

Started by PG Bug reporting form12 months ago6 messagesbugs
Beta feature

Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.

never appliedsuccessCI history

You can run a PostgreSQL built from this patch straight from Docker, with no checkout and no build:

docker run --rm -p 5432:5432 ghcr.io/hackorum-dev/postgres-patch:t73340
psql -h localhost -U postgres

Built from patchset v2 (message #2), July 28, 2026 at 10:53 AM.

Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:

git clone --branch t73340_2 https://github.com/hackorum-dev/postgres.git

In a checkout you already have, add the fork once:

git remote add hackorum https://github.com/hackorum-dev/postgres.git

then, for this patchset and every later one:

git fetch hackorum t73340_2 && git checkout t73340_2

Patchset v2 (message #2) is on t73340_2

Jump to latest
#1PG Bug reporting form
noreply@postgresql.org

The following bug has been logged on the website:

Bug reference: 19080
Logged by: Artem Bezborodko
Email address: doomedseer@gmail.com
PostgreSQL version: 18.0
Operating system: N/A
Description:

Starting from 18 version field "Length of message contents in bytes,
including self." should not have predefined value, due to variable key
length. Now it set as (16).

#2John Naylor
john.naylor@enterprisedb.com
In reply to: PG Bug reporting form (#1)
Re: BUG #19080: CancelRequest message documentation bug

On Thu, Oct 9, 2025 at 9:21 PM PG Bug reporting form
<noreply@postgresql.org> wrote:

Starting from 18 version field "Length of message contents in bytes,
including self." should not have predefined value, due to variable key
length. Now it set as (16).

Seems like an oversight, since the docs describe the v3.2 protocol.
I've attached a fix and CC'd the committer to confirm.

--
John Naylor
Amazon Web Services

Attachments:

t73340_2
protocol-varlen-cancelrequest.patchtext/x-patch; charset=US-ASCII; name=protocol-varlen-cancelrequest.patchDownload+1-1
#3John Naylor
john.naylor@enterprisedb.com
In reply to: PG Bug reporting form (#1)
Re: BUG #19080: CancelRequest message documentation bug

On Thu, Oct 9, 2025 at 9:21 PM PG Bug reporting form
<noreply@postgresql.org> wrote:

Starting from 18 version field "Length of message contents in bytes,
including self." should not have predefined value, due to variable key
length. Now it set as (16).

This was reported last week on the pgsql-docs list, and has been fixed:

/messages/by-id/CAAfz9KML7JCZWZsOc2AWgoUHgmRGoOAOR6L=xDFe9F3_L1uXAQ@mail.gmail.com

--
John Naylor
Amazon Web Services

#4Heikki Linnakangas
heikki.linnakangas@enterprisedb.com
In reply to: John Naylor (#2)
Re: BUG #19080: CancelRequest message documentation bug

On 10 October 2025 05:16:32 CEST, John Naylor <johncnaylorls@gmail.com>
wrote:

On Thu, Oct 9, 2025 at 9:21 PM PG Bug reporting form
<noreply@postgresql.org> wrote:

Starting from 18 version field "Length of message contents in bytes,
including self." should not have predefined value, due to variable key
length. Now it set as (16).

Seems like an oversight, since the docs describe the v3.2 protocol.
I've attached a fix and CC'd the committer to confirm.

Yep, thanks! Feel free to commit the fix, or I can do it on Friday myself.

- Heikki

#5John Naylor
john.naylor@enterprisedb.com
In reply to: Heikki Linnakangas (#4)
Re: BUG #19080: CancelRequest message documentation bug

On Tue, Oct 14, 2025 at 6:39 PM Heikki Linnakangas <hlinnaka@iki.fi> wrote:

Yep, thanks! Feel free to commit the fix, or I can do it on Friday myself.

This has been fixed already, since it was reported on the pgsql-docs
list but I didn't see that until it was committed.

--
John Naylor
Amazon Web Services

#6Magnus Hagander
magnus@hagander.net
In reply to: John Naylor (#5)
Re: BUG #19080: CancelRequest message documentation bug

On Wed, 15 Oct 2025 at 04:30, John Naylor <johncnaylorls@gmail.com> wrote:

On Tue, Oct 14, 2025 at 6:39 PM Heikki Linnakangas <hlinnaka@iki.fi>
wrote:

Yep, thanks! Feel free to commit the fix, or I can do it on Friday

myself.

This has been fixed already, since it was reported on the pgsql-docs
list but I didn't see that until it was committed.

Yeah, and I didn't see the one on -bugs until you pointed it out. Sorry
about that!

--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/&gt;
Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/&gt;