when transaction commit begins
I'd like to reword this line in the Asynch commit docs:
"when transaction commit begins."
Transaction commit is when the transaction ends, so using the word begin
in that way is confusing.
Index: doc/src/sgml/wal.sgml
===================================================================
RCS file: /projects/cvsroot/pgsql/doc/src/sgml/wal.sgml,v
retrieving revision 1.45
diff -c -r1.45 wal.sgml
*** doc/src/sgml/wal.sgml 1 Aug 2007 22:45:07 -0000 1.45
--- doc/src/sgml/wal.sgml 25 Sep 2007 08:01:06 -0000
***************
*** 216,222 ****
<xref linkend="guc-synchronous-commit">, which can be changed in
any of
the ways that a configuration parameter can be set. The mode used
for
any one transaction depends on the value of
! <varname>synchronous_commit</varname> when transaction commit
begins.
</para> <para>
--- 216,223 ----
<xref linkend="guc-synchronous-commit">, which can be changed in
any of
the ways that a configuration parameter can be set. The mode used
for
any one transaction depends on the value of
! <varname>synchronous_commit</varname> at the time of transaction
commit,
! so <command>SET LOCAL</> can also be used.
</para><para>
--
Simon Riggs
2ndQuadrant http://www.2ndQuadrant.com
Simon Riggs <simon@2ndquadrant.com> writes:
I'd like to reword this line in the Asynch commit docs:
"when transaction commit begins."
I do not think your proposed rewording is better. The point I was
trying to cover is that "SET LOCAL synchronous_commit" will affect the
upcoming commit, and that fine point is no longer clear with your
phrasing.
Transaction commit is when the transaction ends, so using the word begin
in that way is confusing.
I don't actually agree with that statement anyway...
regards, tom lane
On Tue, 2007-09-25 at 09:24 -0400, Tom Lane wrote:
Simon Riggs <simon@2ndquadrant.com> writes:
I'd like to reword this line in the Asynch commit docs:
"when transaction commit begins."I do not think your proposed rewording is better.
OK
The point I was
trying to cover is that "SET LOCAL synchronous_commit" will affect the
upcoming commit, and that fine point is no longer clear with your
phrasing.
So we both agree we want to make sure that point is understood. Saying
it explicitly would be the best way, however we word the earlier piece.
--
Simon Riggs
2ndQuadrant http://www.2ndQuadrant.com