Improve pg_restore docs

Started by Mike Toewsalmost 17 years ago5 messagesdocs
Jump to latest
#1Mike Toews
mwtoews@sfu.ca

Hi,

From a quick discussion on hackers
(http://archives.postgresql.org/pgsql-hackers/2009-06/msg01434.php), it
appears the documentation can improve for pg_restore.

I've prepared some quick diff output from
pgsql/doc/src/sgml/ref/pg_restore.sgml for some changes that I think
would help. Note that I'm not entirely sure about the default namespace
from default_path .. please verify this before accepting. Edit as necessary.

291c291,292
< specific table.
---

specific table. The default is taken from the
<envar>default_path</envar> variable.

379c380,382
< Restore definition and/or data of named table only.
---

Restore definition and/or data of named table only. This can be
combined with the <option>-n</option> option to restore a table
from a specific schema.

Thanks,

-Mike

#2Greg Smith
gsmith@gregsmith.com
In reply to: Mike Toews (#1)
Re: Improve pg_restore docs

On Mon, 29 Jun 2009, Mike Toews wrote:

I've prepared some quick diff output from
pgsql/doc/src/sgml/ref/pg_restore.sgml for some changes that I think would
help.

The standard way to submit patches here is to attach a file with a full
context diff (diff -c) to the message, rather than putting it inline or
including just the changes. The idea is to make it easy for the
committers to grab your patch and apply it.

--
* Greg Smith gsmith@gregsmith.com http://www.gregsmith.com Baltimore, MD

#3Mike Toews
mwtoews@sfu.ca
In reply to: Greg Smith (#2)
Re: Improve pg_restore docs

Greg Smith wrote:

The standard way to submit patches here is to attach a file with a
full context diff (diff -c) to the message, rather than putting it
inline or including just the changes. The idea is to make it easy for
the committers to grab your patch and apply it.

Part of my hesitation in attaching the patch is that I'm on a Windows
computer (be aware of CRLF line endings in the attached). Apply to
pgsql/doc/src/sgml/ref/pg_restore.sgml

-Mike

Attachments:

pg_restore.patchtext/plain; name=pg_restore.patchDownload+5-2
#4Greg Smith
gsmith@gregsmith.com
In reply to: Mike Toews (#3)
Re: Improve pg_restore docs

On Mon, 29 Jun 2009, Mike Toews wrote:

Apply to pgsql/doc/src/sgml/ref/pg_restore.sgml

The main point I was trying to make is that we want the whole patch, not
just the change. A standard diff patch will include what file name it is
supposed to apply to as part of its header.

--
* Greg Smith gsmith@gregsmith.com http://www.gregsmith.com Baltimore, MD

#5Bruce Momjian
bruce@momjian.us
In reply to: Mike Toews (#1)
Re: Improve pg_restore docs

Mike Toews wrote:

Hi,

From a quick discussion on hackers
(http://archives.postgresql.org/pgsql-hackers/2009-06/msg01434.php), it
appears the documentation can improve for pg_restore.

I've prepared some quick diff output from
pgsql/doc/src/sgml/ref/pg_restore.sgml for some changes that I think
would help. Note that I'm not entirely sure about the default namespace
from default_path .. please verify this before accepting. Edit as necessary.

291c291,292
< specific table.
---

specific table. The default is taken from the
<envar>default_path</envar> variable.

379c380,382
< Restore definition and/or data of named table only.
---

Restore definition and/or data of named table only. This can be
combined with the <option>-n</option> option to restore a table
from a specific schema.

I have applied a modified version of your second change to our
documentation.

-- 
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com
  PG East:  http://www.enterprisedb.com/community/nav-pg-east-2010.do
  + If your life is a hard drive, Christ can be your backup. +

Attachments:

/rtmp/difftext/x-diffDownload+3-3