typo in release note

Started by Fujii Masaoalmost 16 years ago5 messagesdocs
Jump to latest
#1Fujii Masao
masao.fujii@gmail.com

Hi,

The release note says "Allow continuous archive (WAL) files
to be streamed to a standby system" about SR. But no archive
files are streamed in SR. So we should get rid of the word
"archive" from that sentence? Here is the patch.

Regards,

--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

Attachments:

release_note_typo_sr_v1.patchapplication/octet-stream; name=release_note_typo_sr_v1.patchDownload+4-4
#2Robert Haas
robertmhaas@gmail.com
In reply to: Fujii Masao (#1)
Re: typo in release note

On Thu, Jun 10, 2010 at 4:00 AM, Fujii Masao <masao.fujii@gmail.com> wrote:

The release note says "Allow continuous archive (WAL) files
to be streamed to a standby system" about SR. But no archive
files are streamed in SR. So we should get rid of the word
"archive" from that sentence? Here is the patch.

I don't think that reads very well. Possibly we could remove
"continuous archive" as a whole, but I don't think we can remove one
word and keep the other.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise Postgres Company

#3Tom Lane
tgl@sss.pgh.pa.us
In reply to: Robert Haas (#2)
Re: typo in release note

Robert Haas <robertmhaas@gmail.com> writes:

On Thu, Jun 10, 2010 at 4:00 AM, Fujii Masao <masao.fujii@gmail.com> wrote:

The release note says "Allow continuous archive (WAL) files
to be streamed to a standby system" about SR. But no archive
files are streamed in SR. So we should get rid of the word
"archive" from that sentence? Here is the patch.

I don't think that reads very well. Possibly we could remove
"continuous archive" as a whole, but I don't think we can remove one
word and keep the other.

I'm inclined to think that "continuous archiving" was meant. At least
that's the phrase that is used in chapter 24.

regards, tom lane

#4Robert Haas
robertmhaas@gmail.com
In reply to: Tom Lane (#3)
Re: typo in release note

On Thu, Jun 10, 2010 at 10:16 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:

Robert Haas <robertmhaas@gmail.com> writes:

On Thu, Jun 10, 2010 at 4:00 AM, Fujii Masao <masao.fujii@gmail.com> wrote:

The release note says "Allow continuous archive (WAL) files
to be streamed to a standby system" about SR. But no archive
files are streamed in SR. So we should get rid of the word
"archive" from that sentence? Here is the patch.

I don't think that reads very well.  Possibly we could remove
"continuous archive" as a whole, but I don't think we can remove one
word and keep the other.

I'm inclined to think that "continuous archiving" was meant.  At least
that's the phrase that is used in chapter 24.

Yeah, probably - but I think what Fujii-san is concerned about is
whether streaming replication is a subset of continuous archiving -
the files never actually get "archived".

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise Postgres Company

#5Bruce Momjian
bruce@momjian.us
In reply to: Robert Haas (#4)
Re: typo in release note

Robert Haas wrote:

On Thu, Jun 10, 2010 at 10:16 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:

Robert Haas <robertmhaas@gmail.com> writes:

On Thu, Jun 10, 2010 at 4:00 AM, Fujii Masao <masao.fujii@gmail.com> wrote:

The release note says "Allow continuous archive (WAL) files
to be streamed to a standby system" about SR. But no archive
files are streamed in SR. So we should get rid of the word
"archive" from that sentence? Here is the patch.

I don't think that reads very well. ?Possibly we could remove
"continuous archive" as a whole, but I don't think we can remove one
word and keep the other.

I'm inclined to think that "continuous archiving" was meant. ?At least
that's the phrase that is used in chapter 24.

Yeah, probably - but I think what Fujii-san is concerned about is
whether streaming replication is a subset of continuous archiving -
the files never actually get "archived".

Fujii-san is absolutely right. The original wording assumed streaming
replication and hot standby were a subset of continuous archiving, but I
later realized that you do not need to enable continuous archiving to do
use them, particularly with a sufficiently large wal_keep_segments:

http://momjian.us/main/blogs/pgblog/2010.html#June_16_2010

Attached patch applied.

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ None of us is going to be here forever. +

Attachments:

/rtmp/difftext/x-diffDownload+4-4