release-9.0.sgml changes

Started by Erik Rijkersalmost 16 years ago5 messagesdocs
Jump to latest
#1Erik Rijkers
er@xs4all.nl

Some readability improvements (I hope),
and some typos

Erik Rijkers

Attachments:

release-9.0.sgml.diffapplication/octet-stream; name=release-9.0.sgml.diffDownload+23-25
#2Robert Haas
robertmhaas@gmail.com
In reply to: Erik Rijkers (#1)
Re: release-9.0.sgml changes

On Fri, Jul 9, 2010 at 5:24 PM, Erik Rijkers <er@xs4all.nl> wrote:

Some readability improvements (I hope),
and some typos

You seem to have removed the mention of PL/pgsql being installed by
default, which doesn't seem right.

I also notice that adjacent to one of your changes we have
"privileges" spelled as "priveleges" - this is not a fault in your
patch, but we should probably fix it.

I don't think I agree with these:

-       Fix <command>psql --file -</> to properly honor <link
+       Fix <command>psql --file -</> (i.e. STDIN) to properly honor <link
-      Improve <filename>/contrib/dblink</>s handling of dropped columns
+      Improve <filename>/contrib/dblink</>'s handling of dropped columns

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise Postgres Company

#3Erik Rijkers
er@xs4all.nl
In reply to: Robert Haas (#2)
Re: release-9.0.sgml changes

On Sat, July 10, 2010 02:27, Robert Haas wrote:

On Fri, Jul 9, 2010 at 5:24 PM, Erik Rijkers <er@xs4all.nl> wrote:

Some readability improvements (I hope),
and some typos

You seem to have removed the mention of PL/pgsql being installed by
default, which doesn't seem right.

I just thought it silly to parade such a minimal change in an overview of Major Enhancement Areas.

But obviously none of what I sent matters much. Maybe you (or someone) can just pick out & apply
the obvious typos?

Erik Rijkers

#4Bruce Momjian
bruce@momjian.us
In reply to: Robert Haas (#2)
Re: release-9.0.sgml changes

Robert Haas wrote:

On Fri, Jul 9, 2010 at 5:24 PM, Erik Rijkers <er@xs4all.nl> wrote:

Some readability improvements (I hope),
and some typos

You seem to have removed the mention of PL/pgsql being installed by
default, which doesn't seem right.

I also notice that adjacent to one of your changes we have
"privileges" spelled as "priveleges" - this is not a fault in your
patch, but we should probably fix it.

Fixed.

I don't think I agree with these:

-       Fix <command>psql --file -</> to properly honor <link
+       Fix <command>psql --file -</> (i.e. STDIN) to properly honor <link
-      Improve <filename>/contrib/dblink</>s handling of dropped columns
+      Improve <filename>/contrib/dblink</>'s handling of dropped columns

Agreed.

Remainder of patch applied. Thanks.

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ None of us is going to be here forever. +

Attachments:

/rtmp/difftext/x-diffDownload+44-44
#5Bruce Momjian
bruce@momjian.us
In reply to: Erik Rijkers (#3)
Re: release-9.0.sgml changes

Erik Rijkers wrote:

On Sat, July 10, 2010 02:27, Robert Haas wrote:

On Fri, Jul 9, 2010 at 5:24 PM, Erik Rijkers <er@xs4all.nl> wrote:

Some readability improvements (I hope),
and some typos

You seem to have removed the mention of PL/pgsql being installed by
default, which doesn't seem right.

I just thought it silly to parade such a minimal change in an overview of Major Enhancement Areas.

But obviously none of what I sent matters much. Maybe you (or someone) can just pick out & apply
the obvious typos?

Done. I kept the pl/pgsql default install mention in the release notes.

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ None of us is going to be here forever. +