Patch for some typos in pgarchivecleanup.sgml

Started by Satoshi Nagayasuover 15 years ago3 messagesdocs
Jump to latest
#1Satoshi Nagayasu
satoshi.nagayasu@gmail.com

Hi all,

I found some typos in pgarchivecleanup.sgml.
A patch to fix them is attached in this mail.
Please take a look.

Regards,
--
NAGAYASU Satoshi <satoshi.nagayasu@gmail.com>

Attachments:

pgarchivecleanup.sgml.cvs.patchtext/plain; name=pgarchivecleanup.sgml.cvs.patchDownload+2-2
#2Fujii Masao
masao.fujii@gmail.com
In reply to: Satoshi Nagayasu (#1)
Re: Patch for some typos in pgarchivecleanup.sgml

2010/8/11 Satoshi Nagayasu <satoshi.nagayasu@gmail.com>:

I found some typos in pgarchivecleanup.sgml.
A patch to fix them is attached in this mail.
Please take a look.

-archive_cleanup_command = 'pg_archivecleanup -d .../archive %r 2>>cleanup.log'
+archive_cleanup_command = 'pg_archivecleanup -d ../archive %r 2>>cleanup.log'

This is not a typo. Triple dots ... is used as replaceable part of the path,
and is used also elsewhere. Though I agree that's somewhat confusing.

Regards,

--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

#3Tom Lane
tgl@sss.pgh.pa.us
In reply to: Fujii Masao (#2)
Re: Patch for some typos in pgarchivecleanup.sgml

Fujii Masao <masao.fujii@gmail.com> writes:

2010/8/11 Satoshi Nagayasu <satoshi.nagayasu@gmail.com>:

-archive_cleanup_command = 'pg_archivecleanup -d .../archive %r 2>>cleanup.log'
+archive_cleanup_command = 'pg_archivecleanup -d ../archive %r 2>>cleanup.log'

This is not a typo. Triple dots ... is used as replaceable part of the path,
and is used also elsewhere. Though I agree that's somewhat confusing.

It seems unnecessary to use that convention here, though. I changed it
to read "/mnt/standby/archive", which is consistent with some other
examples in which an NFS mount is assumed.

The standby.log -> cleanup.log change is an obvious typo, in any case.

regards, tom lane