Non-existent cs_log function
It's been pointed out that on the pl/pgsql control structures page
(http://www.postgresql.org/docs/9.0/interactive/plpgsql-control-structures.html)
there's an example using a cs_log function, which doesn't exist. I'm
assuming this is supposed to be an example of a custom logging
function someone might have, but it might cause less confusion if
these were changed to RAISE calls, or something else that exists.
What do you think?
--
Thom Brown
Twitter: @darkixion
IRC (freenode): dark_ixion
Registered Linux user: #516935
On Fri, Feb 11, 2011 at 8:46 PM, Thom Brown <thom@linux.com> wrote:
It's been pointed out that on the pl/pgsql control structures page
(http://www.postgresql.org/docs/9.0/interactive/plpgsql-control-structures.html)
there's an example using a cs_log function, which doesn't exist. I'm
assuming this is supposed to be an example of a custom logging
function someone might have, but it might cause less confusion if
these were changed to RAISE calls, or something else that exists.What do you think?
I agree.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Thom Brown wrote:
It's been pointed out that on the pl/pgsql control structures page
(http://www.postgresql.org/docs/9.0/interactive/plpgsql-control-structures.html)
there's an example using a cs_log function, which doesn't exist. I'm
assuming this is supposed to be an example of a custom logging
function someone might have, but it might cause less confusion if
these were changed to RAISE calls, or something else that exists.What do you think?
Done, in the attached applied patch.
--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ It's impossible for everything to be true. +
Attachments:
/rtmp/raise.difftext/x-diffDownload+3-4
On 11 March 2011 13:48, Bruce Momjian <bruce@momjian.us> wrote:
Thom Brown wrote:
It's been pointed out that on the pl/pgsql control structures page
(http://www.postgresql.org/docs/9.0/interactive/plpgsql-control-structures.html)
there's an example using a cs_log function, which doesn't exist. I'm
assuming this is supposed to be an example of a custom logging
function someone might have, but it might cause less confusion if
these were changed to RAISE calls, or something else that exists.What do you think?
Done, in the attached applied patch.
That's great. Thanks Bruce.
--
Thom Brown
Twitter: @darkixion
IRC (freenode): dark_ixion
Registered Linux user: #516935
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company