Missing doc for operator args in alter extension

Started by Daniele Varrazzoabout 15 years ago4 messagesdocs
Jump to latest
#1Daniele Varrazzo
daniele.varrazzo@gmail.com

Hello,

the documentation for ALTER EXTENSION is missing the description for
the arguments of the form ADD OPERATOR name (left_type, right_type).

Albeit it's pretty obvious what they are, it is not so obvious what to
do for unary operators (i.e. replace the type on the missing side with
NONE).

Patch to fix the doc attached.

-- Daniele

Attachments:

alter_extension_operator_args.patchtext/x-patch; charset=US-ASCII; name=alter_extension_operator_args.patchDownload+12-0
#2Robert Haas
robertmhaas@gmail.com
In reply to: Daniele Varrazzo (#1)
Re: Missing doc for operator args in alter extension

On Mon, Apr 4, 2011 at 9:10 PM, Daniele Varrazzo
<daniele.varrazzo@gmail.com> wrote:

Hello,

the documentation for ALTER EXTENSION is missing the description for
the arguments of the form ADD OPERATOR name (left_type, right_type).

Albeit it's pretty obvious what they are, it is not so obvious what to
do for unary operators (i.e. replace the type on the missing side with
NONE).

Patch to fix the doc attached.

I think we might want to make the synopsis, as well as the description
of left_arg and right_arg, match what's on the DROP OPERATOR page.

Thoughts?

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

#3Tom Lane
tgl@sss.pgh.pa.us
In reply to: Robert Haas (#2)
Re: Missing doc for operator args in alter extension

Robert Haas <robertmhaas@gmail.com> writes:

On Mon, Apr 4, 2011 at 9:10 PM, Daniele Varrazzo
<daniele.varrazzo@gmail.com> wrote:

the documentation for ALTER EXTENSION is missing the description for
the arguments of the form ADD OPERATOR name (left_type, right_type).

I think we might want to make the synopsis, as well as the description
of left_arg and right_arg, match what's on the DROP OPERATOR page.

I think I borrowed that text from the COMMENT page. Should probably
look at that too.

regards, tom lane

#4Robert Haas
robertmhaas@gmail.com
In reply to: Tom Lane (#3)
Re: Missing doc for operator args in alter extension

On Thu, Apr 7, 2011 at 9:49 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:

Robert Haas <robertmhaas@gmail.com> writes:

On Mon, Apr 4, 2011 at 9:10 PM, Daniele Varrazzo
<daniele.varrazzo@gmail.com> wrote:

the documentation for ALTER EXTENSION is missing the description for
the arguments of the form ADD OPERATOR name (left_type, right_type).

I think we might want to make the synopsis, as well as the description
of left_arg and right_arg, match what's on the DROP OPERATOR page.

I think I borrowed that text from the COMMENT page.  Should probably
look at that too.

Looks like you just failed to borrow quite enough. Additional
borrowing committed.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company