Improve FDW document (for 9.1)

Started by Shigeru Hanadaalmost 15 years ago2 messagesdocs
Jump to latest
#1Shigeru Hanada
shigeru.hanada@gmail.com

Hi,

During reading Albe's patch for FDW validator attached to "Bug in
SQL/MED?" posted to pgsql-hackers[1]http://archives.postgresql.org/pgsql-hackers/2011-06/msg02230.php, I noticed that neither ALTER
commands nor USER MAPPING is mentioned in the description of FDW
validator in "Writing A Foreign Data Wrapper"[2]http://developer.postgresql.org/pgdocs/postgres/fdwhandler.html. The validator
function is also called for ALTER commands and USER MAPPING
manipulation, if any FDW option remains.

FYI, Albe's patch is for calling validator even if no option remains.

[1]: http://archives.postgresql.org/pgsql-hackers/2011-06/msg02230.php
[2]: http://developer.postgresql.org/pgdocs/postgres/fdwhandler.html

Please find attached a patch which adds a mention of ALTER and USER MAPPING.

Regards,
--
Shigeru Hanada

Attachments:

fdw_doc.patchtext/plain; name=fdw_doc.patchDownload+8-3
#2Tom Lane
tgl@sss.pgh.pa.us
In reply to: Shigeru Hanada (#1)
Re: Improve FDW document (for 9.1)

Shigeru Hanada <shigeru.hanada@gmail.com> writes:

During reading Albe's patch for FDW validator attached to "Bug in
SQL/MED?" posted to pgsql-hackers[1], I noticed that neither ALTER
commands nor USER MAPPING is mentioned in the description of FDW
validator in "Writing A Foreign Data Wrapper"[2]. The validator
function is also called for ALTER commands and USER MAPPING
manipulation, if any FDW option remains.

Please find attached a patch which adds a mention of ALTER and USER MAPPING.

Applied with some editorial adjustments.

regards, tom lane