Re: misspellings & typofixes
On Thu, Apr 12, 2012 at 7:17 PM, Josh Kupershmidt <schmiddy@gmail.com> wrote:
Attached is a big patch fixing obvious typos/misspellings.
And here's a separate patch with a few more I turned up.
Josh
Attachments:
typos.round2.diffapplication/octet-stream; name=typos.round2.diffDownload+6-6
Import Notes
Reply to msg id not found: CAK3UJRGCFg2jfsGom0EnrFhzdTciJD+BFcXpKUm5P4qgioUEYg@mail.gmail.comReference msg id not found: CAK3UJRGCFg2jfsGom0EnrFhzdTciJD+BFcXpKUm5P4qgioUEYg@mail.gmail.com
On lör, 2012-04-21 at 10:49 -0700, Josh Kupershmidt wrote:
On Thu, Apr 12, 2012 at 7:17 PM, Josh Kupershmidt <schmiddy@gmail.com> wrote:
Attached is a big patch fixing obvious typos/misspellings.
And here's a separate patch with a few more I turned up.
Committed.
On Sun, Apr 22, 2012 at 9:24 AM, Peter Eisentraut <peter_e@gmx.net> wrote:
On lör, 2012-04-21 at 10:49 -0700, Josh Kupershmidt wrote:
On Thu, Apr 12, 2012 at 7:17 PM, Josh Kupershmidt <schmiddy@gmail.com> wrote:
Attached is a big patch fixing obvious typos/misspellings.
And here's a separate patch with a few more I turned up.
Committed.
Thanks! [Just to avoid confusion, the first patch is still unapplied].
Josh
On sön, 2012-04-22 at 21:26 -0700, Josh Kupershmidt wrote:
On Sun, Apr 22, 2012 at 9:24 AM, Peter Eisentraut <peter_e@gmx.net> wrote:
On lör, 2012-04-21 at 10:49 -0700, Josh Kupershmidt wrote:
On Thu, Apr 12, 2012 at 7:17 PM, Josh Kupershmidt <schmiddy@gmail.com> wrote:
Attached is a big patch fixing obvious typos/misspellings.
And here's a separate patch with a few more I turned up.
Committed.
Thanks! [Just to avoid confusion, the first patch is still unapplied].
Uh, just to add to the confusion, I don't see any other similar patch
from you.
On Mon, Apr 23, 2012 at 11:39 AM, Peter Eisentraut <peter_e@gmx.net> wrote:
On sön, 2012-04-22 at 21:26 -0700, Josh Kupershmidt wrote:
On Sun, Apr 22, 2012 at 9:24 AM, Peter Eisentraut <peter_e@gmx.net> wrote:
On lör, 2012-04-21 at 10:49 -0700, Josh Kupershmidt wrote:
On Thu, Apr 12, 2012 at 7:17 PM, Josh Kupershmidt <schmiddy@gmail.com> wrote:
Attached is a big patch fixing obvious typos/misspellings.
And here's a separate patch with a few more I turned up.
Committed.
Thanks! [Just to avoid confusion, the first patch is still unapplied].
Uh, just to add to the confusion, I don't see any other similar patch
from you.
Maybe the list ate it because the patch was too big :-(
Below is my original email, and I'll attach a gzip'ed version of the
original patch instead.
Josh
---------- Forwarded message ----------
From: Josh Kupershmidt <schmiddy@gmail.com>
Date: Thu, Apr 12, 2012 at 7:17 PM
Subject: misspellings & typofixes
To: pgsql-docs <pgsql-docs@postgresql.org>
Hi all,
Attached is a big patch fixing obvious typos/misspellings. I'd been
sitting on a few, and also used a script to search out common
errors[1]I ran through this list: http://en.wikipedia.org/wiki/Wikipedia:Lists_of_common_misspellings/For_machines.
While I was mucking around, these two comments caught my eye:
*** a/src/pl/plperl/plperl_helpers.h
--- b/src/pl/plperl/plperl_helpers.h
*************** sv2cstr(SV *sv)
*** 62,68 ****
(SvTYPE(sv) > SVt_PVLV && SvTYPE(sv) != SVt_PVFM))
sv = newSVsv(sv);
else
! /* increase the reference count so we cant just
SvREFCNT_dec() it when
* we are done */
SvREFCNT_inc(sv);I'm by no means familiar with that code, but perhaps the "cant" in the
comment should be "can"? Ditto for this comment:
*** a/contrib/pgcrypto/pgp-compress.c
--- b/contrib/pgcrypto/pgp-compress.c
*************** compress_init(PushFilter *next, void *in
*** 105,111 ****/* writes compressed data packet */
! /* cant handle zero-len incoming data, but shouldnt */
static int
compress_process(PushFilter *next, void *priv, const uint8 *data, int len)
{
(and the contractions in the above comments should use apostrophes, in
any case).
I noticed additional misspellings, e.g.
* "ficticious", "goverment" and "Ukranian" in ./src/timezone/data/europe
* "millenium" in ./src/timezone/data/australasia
* "offical" and "Acording" in ./src/timezone/data/southamerica
* "sence" in ./src/timezone/data/asia
* "Antartic" in ./src/timezone/data/antarctica
which I didn't try to fix, as these seem like a problem for IANA upstream.
There are also few instances of dubious lingo, like "wanna" or "thru",
which I also left alone.
Josh
--
[1]: I ran through this list: http://en.wikipedia.org/wiki/Wikipedia:Lists_of_common_misspellings/For_machines
http://en.wikipedia.org/wiki/Wikipedia:Lists_of_common_misspellings/For_machines
Attachments:
On Mon, Apr 23, 2012 at 8:30 PM, Josh Kupershmidt <schmiddy@gmail.com> wrote:
Below is my original email, and I'll attach a gzip'ed version of the
original patch instead.
I see Robert applied the patch (thanks!).
Did anyone else think the two comments I pointed out were in need of
fixing? Possible patch for those attached.
Josh
Attachments:
fix_misleading_comments.diffapplication/octet-stream; name=fix_misleading_comments.diffDownload+4-4
On tis, 2012-05-08 at 01:29 +0000, Josh Kupershmidt wrote:
On Mon, Apr 23, 2012 at 8:30 PM, Josh Kupershmidt <schmiddy@gmail.com> wrote:
Below is my original email, and I'll attach a gzip'ed version of the
original patch instead.I see Robert applied the patch (thanks!).
Did anyone else think the two comments I pointed out were in need of
fixing? Possible patch for those attached.
committed