misleading lang_name case in CREATE FUNCTION doc.

Started by Marc Maminover 12 years ago6 messagesdocs
Jump to latest
#1Marc Mamin
M.Mamin@intershop.de

Hi,
you might want to lowercase the language names in order to be compatible with the case restriction introduced in 9.2.
or add a sentence like
'when using single quotes, the names are case sensitive (with is lowercase for most (all?) languages).

regards,

Marc Mamin

http://www.postgresql.org/docs/9.3/static/sql-createfunction.html

lang_name

The name of the language that the function is implemented in.
Can be SQL, C, internal, or the name of a user-defined procedural language.
For backward compatibility, the name can be enclosed by single quotes.

http://www.postgresql.org/docs/current/static/release-9-2.html

No longer forcibly lowercase procedural language names in CREATE FUNCTION (Robert Haas)

While unquoted language identifiers are still lowercased,
strings and quoted identifiers are no longer forcibly down-cased.
Thus for example CREATE FUNCTION ... LANGUAGE 'C' will no longer work;
it must be spelled 'c', or better omit the quotes.

#2Peter Eisentraut
peter_e@gmx.net
In reply to: Marc Mamin (#1)
Re: misleading lang_name case in CREATE FUNCTION doc.

On Fri, 2013-10-11 at 08:37 +0000, Marc Mamin wrote:

Hi,
you might want to lowercase the language names in order to be
compatible with the case restriction introduced in 9.2.
or add a sentence like
'when using single quotes, the names are case sensitive (with is
lowercase for most (all?) languages).

Yeah, I'm having trouble coming up with a wording that is sufficiently
brief. We don't want the backward compatibility text to be longer than
the main description, I think.

--
Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs

#3Marc Mamin
M.Mamin@intershop.de
In reply to: Peter Eisentraut (#2)
Re: misleading lang_name case in CREATE FUNCTION doc.

From: Peter Eisentraut [mailto:peter_e@gmx.net]
Sent: Mittwoch, 13. November 2013 12:56

On Fri, 2013-10-11 at 08:37 +0000, Marc Mamin wrote:

Hi,
you might want to lowercase the language names in order to be
compatible with the case restriction introduced in 9.2.
or add a sentence like
'when using single quotes, the names are case sensitive (with is
lowercase for most (all?) languages).

Yeah, I'm having trouble coming up with a wording that is sufficiently
brief. We don't want the backward compatibility text to be longer than
the main description, I think.

something like :?

The name of the language that the function is implemented in.
Can be 'sql', 'c', 'internal', or the name of a user-defined procedural language.
Single quotes are optional, they required correct case when used.

regards,

Marc Mamin

--
Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs

#4Peter Eisentraut
peter_e@gmx.net
In reply to: Marc Mamin (#3)
Re: misleading lang_name case in CREATE FUNCTION doc.

On 11/13/13, 9:02 AM, Marc Mamin wrote:

something like :?

The name of the language that the function is implemented in.
Can be 'sql', 'c', 'internal', or the name of a user-defined procedural language.
Single quotes are optional, they required correct case when used.

That would make the deprecated syntax more prominent than the
non-deprecated one. We want to get rid of the single quotes.

--
Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs

#5Marc Mamin
M.Mamin@intershop.de
In reply to: Peter Eisentraut (#4)
Re: misleading lang_name case in CREATE FUNCTION doc.

Von: Peter Eisentraut [peter_e@gmx.net]

On 11/13/13, 9:02 AM, Marc Mamin wrote:
something like :?

The name of the language that the function is implemented in.
Can be 'sql', 'c', 'internal', or the name of a user-defined procedural language.
Single quotes are optional, they required correct case when used.

That would make the deprecated syntax more prominent than the
non-deprecated one. We want to get rid of the single quotes.

Ok, next try :)

The name of the language that the function is implemented in.
Can be sql, c, internal, or the name of a user-defined procedural language.
Single quotes are deprecated. They require correct case when used.

regards,
Marc Mamin

--
Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs

#6Bruce Momjian
bruce@momjian.us
In reply to: Marc Mamin (#5)
Re: misleading lang_name case in CREATE FUNCTION doc.

On Tue, Nov 26, 2013 at 07:28:17PM +0000, Marc Mamin wrote:

Von: Peter Eisentraut [peter_e@gmx.net]

On 11/13/13, 9:02 AM, Marc Mamin wrote:
something like :?

The name of the language that the function is implemented in.
Can be 'sql', 'c', 'internal', or the name of a user-defined procedural language.
Single quotes are optional, they required correct case when used.

That would make the deprecated syntax more prominent than the
non-deprecated one. We want to get rid of the single quotes.

Ok, next try :)

The name of the language that the function is implemented in.
Can be sql, c, internal, or the name of a user-defined procedural language.
Single quotes are deprecated. They require correct case when used.

I have applied the attached patch to improve the wording. Thanks for
the report.

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ Everyone has their own god. +

Attachments:

lang.difftext/x-diff; charset=us-asciiDownload+6-6