Minor addition to index documentation

Started by Anastasia Lubennikovaover 10 years ago4 messagesdocs
Jump to latest
#1Anastasia Lubennikova
a.lubennikova@postgrespro.ru

Fix incomplete gist interface description.
Patch is attached.

--
Anastasia Lubennikova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

Attachments:

gist_fetch_docs_update.patchtext/x-patch; name=gist_fetch_docs_update.patchDownload+6-1
#2Alvaro Herrera
alvherre@2ndquadrant.com
In reply to: Anastasia Lubennikova (#1)
Re: Minor addition to index documentation

Anastasia Lubennikova wrote:

Fix incomplete gist interface description.

Hi, thanks for the patch.

I think this sentence is a bit confusing:

<para>
-   GiST indexes require seven support functions, with an optional eighth, as
+   GiST indexes require seven support functions, with two optional, as
shown in <xref linkend="xindex-gist-support-table">.

The new text seems to say that one of the seven support funcs is
optional, which is wrong if I correctly understand that the "fetch"
optional function was added.

Maybe "GiST indexes require nine support functions, two of which are
optional, as shown in XYZ".

This is to be backpatched as far back as commit d04c8ed9044ec, right?

--
�lvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

--
Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs

#3Anastasia Lubennikova
a.lubennikova@postgrespro.ru
In reply to: Alvaro Herrera (#2)
Re: Minor addition to index documentation

16.11.2015 21:59, Alvaro Herrera:

Anastasia Lubennikova wrote:

Fix incomplete gist interface description.

Hi, thanks for the patch.

I think this sentence is a bit confusing:

<para>
-   GiST indexes require seven support functions, with an optional eighth, as
+   GiST indexes require seven support functions, with two optional, as
shown in <xref linkend="xindex-gist-support-table">.

The new text seems to say that one of the seven support funcs is
optional, which is wrong if I correctly understand that the "fetch"
optional function was added.

Maybe "GiST indexes require nine support functions, two of which are
optional, as shown in XYZ".

Yes, thank you for advice. I think it'll be more clear.

This is to be backpatched as far back as commit d04c8ed9044ec, right?

Yes.

--
Anastasia Lubennikova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

Attachments:

gist_fetch_docs_update_1.0.patchtext/x-patch; name=gist_fetch_docs_update_1.0.patchDownload+6-1
#4Tom Lane
tgl@sss.pgh.pa.us
In reply to: Alvaro Herrera (#2)
Re: Minor addition to index documentation

Alvaro Herrera <alvherre@2ndquadrant.com> writes:

Maybe "GiST indexes require nine support functions, two of which are
optional, as shown in XYZ".

That wording seems just as bizarre to me: a support function can hardly
be both "required" and "optional". After a bit of thought I changed it
to
GiST indexes have nine support functions, two of which are optional,

I noted that the corresponding wording for GIN indexes was a bit out
of date too :-(. Pushed with those corrections.

regards, tom lane

--
Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs