Better example

Started by Don Morrisonover 9 years ago4 messagesdocs
Jump to latest
#1Don Morrison
dfm@ringing.org

The following documentation comment has been logged on the website:

Page: https://www.postgresql.org/docs/9.5/static/datatype-numeric.html
Description:

I think that in the section on floating point Infinity/-Infinity/NaN in the
Data Types chapter the example would be better setting it to -Infinity
rather than positive, as that would make clear that the minus sign needs to
be within the quote marks. This isn't clear otherwise.

--
Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs

#2Bruce Momjian
bruce@momjian.us
In reply to: Don Morrison (#1)
Re: Better example

On Tue, Nov 8, 2016 at 06:01:58PM +0000, dfm@ringing.org wrote:

The following documentation comment has been logged on the website:

Page: https://www.postgresql.org/docs/9.5/static/datatype-numeric.html
Description:

I think that in the section on floating point Infinity/-Infinity/NaN in the
Data Types chapter the example would be better setting it to -Infinity
rather than positive, as that would make clear that the minus sign needs to
be within the quote marks. This isn't clear otherwise.

Is the attached patch what you are suggesting?

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ As you are, so once was I.  As I am, so you will be. +
+                      Ancient Roman grave inscription +

Attachments:

infinity.difftext/x-diff; charset=us-asciiDownload+2-2
#3Don Morrison
dfm@ringing.org
In reply to: Bruce Momjian (#2)
Re: Better example

On Wed, Nov 23, 2016 at 12:59 PM, Bruce Momjian <bruce@momjian.us> wrote:

Is the attached patch what you are suggesting?

Yup, b is what I had in mind.

Thanks!

--
Don Morrison <dfm@ringing.org>
"Nobody minds having what is too good for them."
-- Jane Austen, _Mansfield Park_

#4Bruce Momjian
bruce@momjian.us
In reply to: Bruce Momjian (#2)
Re: Better example

On Wed, Nov 23, 2016 at 12:59:41PM -0500, Bruce Momjian wrote:

On Tue, Nov 8, 2016 at 06:01:58PM +0000, dfm@ringing.org wrote:

The following documentation comment has been logged on the website:

Page: https://www.postgresql.org/docs/9.5/static/datatype-numeric.html
Description:

I think that in the section on floating point Infinity/-Infinity/NaN in the
Data Types chapter the example would be better setting it to -Infinity
rather than positive, as that would make clear that the minus sign needs to
be within the quote marks. This isn&#39;t clear otherwise.

Is the attached patch what you are suggesting?

Patch applied.

---------------------------------------------------------------------------

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ As you are, so once was I.  As I am, so you will be. +
+                      Ancient Roman grave inscription +
diff --git a/doc/src/sgml/datatype.sgml b/doc/src/sgml/datatype.sgml
new file mode 100644
index 67d0c34..fbc3576
*** a/doc/src/sgml/datatype.sgml
--- b/doc/src/sgml/datatype.sgml
*************** FROM generate_series(-3.5, 3.5, 1) as x;
*** 750,756 ****
floating-point arithmetic does not follow IEEE 754, these values
will probably not work as expected.)  When writing these values
as constants in an SQL command, you must put quotes around them,
!      for example <literal>UPDATE table SET x = 'Infinity'</>.  On input,
these strings are recognized in a case-insensitive manner.
</para>
--- 750,756 ----
floating-point arithmetic does not follow IEEE 754, these values
will probably not work as expected.)  When writing these values
as constants in an SQL command, you must put quotes around them,
!      for example <literal>UPDATE table SET x = '-Infinity'</>.  On input,
these strings are recognized in a case-insensitive manner.
</para>

--
Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ As you are, so once was I.  As I am, so you will be. +
+                      Ancient Roman grave inscription +

--
Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs